Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mutation and action payload optional in definition file #1517

Merged
merged 2 commits into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@davidsandoz
Copy link
Contributor

davidsandoz commented Mar 7, 2019

When testing a mutation without payload in TypeScript, it complains that about the missing payload, even though it's not mandatory.

This PR simply makes the payload optional.

Fixes #1491

Make mutation payload optional in definition file
When testing a mutation without payload in TypeScript, it complains that about the missing payload, even though it's not mandatory.

This PR simply makes the payload optional.

Fixes #1491
@ktsn
Copy link
Member

ktsn left a comment

Thanks for your PR.
Please make the same change for action payload 🙂

@davidsandoz davidsandoz changed the title Make mutation payload optional in definition file Make mutation and action payload optional in definition file Mar 9, 2019

@davidsandoz

This comment has been minimized.

Copy link
Contributor Author

davidsandoz commented Mar 9, 2019

@ktsn, change for action payload is now done as well.

@ktsn

ktsn approved these changes Mar 10, 2019

Copy link
Member

ktsn left a comment

Thank you!

@ktsn ktsn merged commit 0e109e2 into vuejs:dev Mar 10, 2019

6 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.