Skip to content

Clarify nested modules requirement for array in docs #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2021
Merged

Clarify nested modules requirement for array in docs #1933

merged 2 commits into from
Mar 25, 2021

Conversation

bikingbadger
Copy link
Contributor

fixes: #1781

Documents the nested modules requirement of being an array and not a string.

cuebit
cuebit requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@cuebit cuebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Please review the comment and I think this is good to be merged.

@cuebit cuebit added 4.x documentation Improvements or additions to documentation labels Mar 25, 2021
cuebit
cuebit approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@cuebit cuebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cuebit cuebit merged commit 452fd5f into vuejs:4.0 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuebit cuebit cuebit approved these changes

Assignees
No one assigned
Labels
4.x documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bikingbadger @cuebit