Update getter docs #601
Merged
Update getter docs #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility to return functions in getters (#598)
ktsn
reviewed
Jan 27, 2017
| return getters.todos.find(todo => todo.id === id) | ||
| } | ||
| // function syntax | ||
| getTodoById: function(state, getters){ |
There was a problem hiding this comment.
Is this necessary? I feel only the arrow function example is enough.
There was a problem hiding this comment.
Honestly, I didn't I know you could do this with getters until I saw this commit. I'm sure many like myself will also benefit from this example.
There was a problem hiding this comment.
As this example has the same meaning as the above example, I'm still not sure why we need both the arrow function and normal function version in Vuex docs.
| @@ -61,6 +61,27 @@ computed: { | |||
| } | |||
| ``` | |||
|
|
|||
| You can also return functions in getters: | |||
There was a problem hiding this comment.
It would be nice if there is a statement that describes this pattern is for passing some arguments to getters. 🙂
more detailed description and removed function syntax
|
Added a bit more details on possible uses to the description |
ktsn
approved these changes
Jan 27, 2017
|
Thanks! |
ktsn
added a commit
to ktsn/vuex
that referenced
this pull request
Feb 19, 2017
Merged
ktsn
added a commit
that referenced
this pull request
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to return functions in getters (#598)