Skip to content

[improvement] Add assertion to verify using of new #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2017
Merged

[improvement] Add assertion to verify using of new #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be4fffb
[improvement] Add assertion to verify using of new
termosa Mar 19, 2017
7d2c3e3
[fix] Revert dist folder
termosa Mar 19, 2017
684eac4
Merge branch 'dev' into dev
ktsn May 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export class Store {
constructor (options = {}) {
assert(Vue, `must call Vue.use(Vuex) before creating a store instance.`)
assert(typeof Promise !== 'undefined', `vuex requires a Promise polyfill in this browser.`)
assert(this instanceof Store, `Store must be called with the new operator.`)

const {
plugins = [],
Expand Down
6 changes: 6 additions & 0 deletions test/unit/store.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,12 @@ describe('Store', () => {
})
})

it('asserts the call with the new operator', () => {
expect(() => {
Vuex.Store({})
}).toThrowError(/Store must be called with the new operator/)
})

it('should accept state as function', () => {
const store = new Vuex.Store({
state: () => ({
Expand Down