Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to docs #763

Closed
wants to merge 2 commits into from
Closed

Add logo to docs #763

wants to merge 2 commits into from

Conversation

marshallswain
Copy link

This project deserves its own logo. This adds a 2kb svg file to each language in the vuex@2.x docs.

Preview:
screen shot 2017-05-01 at 7 45 14 am

@posva
Copy link
Member

posva commented May 1, 2017

Good job, although, I think it'd be better if the logo reminds of the cycle as the redux logo does

@marshallswain
Copy link
Author

@posva Thanks. I thought about that. I'll see if I can work something in.

@phanan
Copy link
Member

phanan commented May 1, 2017

Not a designer, but I think the width-height proportion of the logo is a bit… strange. A more square-ish logo (width~height) would fit better for other purposes e.g. favicons and all.

@marshallswain
Copy link
Author

marshallswain commented May 2, 2017

Here's a new logo revision. I tried a bunch of combinations of orbits. Two orbits stays the cleanest without ruining the Xsymbol. The "atoms" are offset to add a bit of movement and prevent it from looking like a circular cage with reinforced welds. Adding more rings makes it feel like a hazmat symbol due to the sharp edges inside the circular areas ;) The rings also help to square it up a bit, which is a valid point that @phanan mentioned. It was only a few pixels off square, before, but I think it's a good idea. For smaller sizes, like a favicon, I would probably stick to one, thicker orbit. I also brought the central diamond shape to the front of the orbit rings to emphasize the embedded Vue logo and the X, underneath.

screen shot 2017-05-02 at 12 40 14 am

I've already updated the PR with this new logo because I think it's a clear improvement over the earlier one.

@posva
Copy link
Member

posva commented May 2, 2017 via email

@marshallswain
Copy link
Author

marshallswain commented May 2, 2017

No X, Centered Orbits
no-x-centered-atoms

No X, Centered Orbits, Darker Orbit
no-x-centered-atoms copy

Lighter X, Centered Orbits, Darker Orbit
centered-atoms-lighter-x copy

Centered Orbits:
centered-atoms-lighter-x

@anteriovieira
Copy link

No X, Centered Orbits, Darker Orbit 👍

@marshallswain
Copy link
Author

marshallswain commented May 3, 2017

Heh. The X isn't really needed, anymore. It's in the orbits. This is why I'm not a designer. I'm a hobbyist. 😉 I definitely prefer it without the x.

@yyx990803
Copy link
Member

Hey @marshallswain - thanks a lot for the proposal! I actually thought of designing logos for sub-projects too, but ended up not really doing it because vuex and vue-router are both tightly coupled to Vue and I'd rather just use a single logo to represent the entire Vue stack :) Plus it's also hard to get it right (annnnd we'd need one for vue-router too if we have one for vuex?) But still, really appreciate your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants