Skip to content

perf: render pages in parallel #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

perf: render pages in parallel #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions packages/bundler-vite/src/build/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { CreateVueAppFunction } from '@vuepress/client'
import type { App, Bundler } from '@vuepress/core'
import { colors, debug, fs, importFile, withSpinner } from '@vuepress/utils'
import { debug, fs, importFile, withSpinner } from '@vuepress/utils'
import type { OutputAsset, OutputChunk, RollupOutput } from 'rollup'
import { build as viteBuild } from 'vite'
import { resolveViteConfig } from '../resolveViteConfig.js'
Expand Down Expand Up @@ -73,20 +73,21 @@ export const build = async (
const { renderToString } = await import('vue/server-renderer')

// pre-render pages to html files
for (const page of app.pages) {
if (spinner) spinner.text = `Rendering pages ${colors.magenta(page.path)}`
await renderPage({
app,
page,
vueApp,
vueRouter,
renderToString,
ssrTemplate,
output: clientOutput.output,
outputEntryChunk: clientEntryChunk,
outputCssAsset: clientCssAsset,
})
}
await Promise.all(
app.pages.map((page) =>
renderPage({
app,
page,
vueApp,
vueRouter,
renderToString,
ssrTemplate,
output: clientOutput.output,
outputEntryChunk: clientEntryChunk,
outputCssAsset: clientCssAsset,
})
)
)
})

// keep the server bundle files in debug mode
Expand Down
41 changes: 17 additions & 24 deletions packages/bundler-webpack/src/build/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import type { CreateVueAppFunction } from '@vuepress/client'
import type { App, Bundler } from '@vuepress/core'
import {
colors,
debug,
fs,
importFileDefault,
withSpinner,
} from '@vuepress/utils'
import { debug, fs, importFileDefault, withSpinner } from '@vuepress/utils'
import webpack from 'webpack'
import { resolveWebpackConfig } from '../resolveWebpackConfig.js'
import type { WebpackBundlerOptions } from '../types.js'
Expand Down Expand Up @@ -96,23 +90,22 @@ export const build = async (
const { renderToString } = await import('vue/server-renderer')

// pre-render pages to html files
for (const page of app.pages) {
if (spinner) {
spinner.text = `Rendering pages ${colors.magenta(page.path)}`
}
await renderPage({
app,
page,
vueApp,
vueRouter,
renderToString,
ssrTemplate,
allFilesMeta,
initialFilesMeta,
asyncFilesMeta,
moduleFilesMetaMap,
})
}
await Promise.all(
app.pages.map((page) =>
renderPage({
app,
page,
vueApp,
vueRouter,
renderToString,
ssrTemplate,
allFilesMeta,
initialFilesMeta,
asyncFilesMeta,
moduleFilesMetaMap,
})
)
)
})

// keep the server bundle files in debug mode
Expand Down