refactor(utils): migrate from globby to tinyglobby #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16752847698Details
💛 - Coveralls |
BREAKING CHANGE: the `globby` export has been replaced by `tinyglobby` in `vuepress/utils` package
meteorlxy
changed the title
|
这玩意儿不应该是refactor吧，至少我觉得ecosystem会崩 |
|
I realized it and added BREAKING CHANGE note in d906b01 |
|
@Mister-Hope Any concern about this change in ecosystem? |
|
The export name changes, so at least I think this should be marked as breaking, no functionality concerns, just a rename is needed downstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123).What is the purpose of this pull request?
Description
Screenshots
Before
After