-
Notifications
You must be signed in to change notification settings - Fork 76
feat(plugin-meilisearch): support meilisearch #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs are missing |
Pull Request Test Coverage Report for Build 14427200352Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new feature that integrates Meilisearch-based search functionality into the repo. Key changes include:
- Definition of shared types for Meilisearch options.
- Implementation of the VuePress plugin with both node and client configurations.
- Setup of client components to render the search box.
Reviewed Changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
plugins/search/plugin-meilisearch/src/shared/index.ts | Added shared type definitions for Meilisearch options. |
plugins/search/plugin-meilisearch/src/node/option.ts | Introduced plugin options type alias based on shared types. |
plugins/search/plugin-meilisearch/src/node/meiliSearchPlugin.ts | Created the plugin definition for Meilisearch integration. |
plugins/search/plugin-meilisearch/src/node/index.ts | Re-exported plugin definitions (note a potential syntax issue). |
plugins/search/plugin-meilisearch/src/client/config.ts | Configured client enhancements using the defined search component. |
plugins/search/plugin-meilisearch/src/client/components/index.ts | Exported the MeiliSearch component. |
plugins/search/plugin-meilisearch/src/client/components/MeiliSearch.ts | Defined the MeiliSearch component and its behavior on mount. |
plugins/search/plugin-meilisearch/rollup.config.ts | Configured bundling for node and client code via Rollup. |
Files not reviewed (4)
- plugins/search/plugin-meilisearch/package.json: Language not supported
- plugins/search/plugin-meilisearch/tsconfig.build.json: Language not supported
- pnpm-lock.yaml: Language not supported
- tsconfig.build.json: Language not supported
There is only 1 blocking things left: Search results are not filtered by locales in your demo, and related docs are not updated either. @JQiue Can you handle this? |
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
Screenshots
Before
After