Skip to content

Conversation

JQiue
Copy link
Contributor

@JQiue JQiue commented Mar 31, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

Screenshots

Before

After

@Mister-Hope
Copy link
Member

docs are missing

@coveralls
Copy link

coveralls commented Apr 1, 2025

Pull Request Test Coverage Report for Build 14427200352

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.517%

Totals Coverage Status
Change from base Build 14427199235: 0.0%
Covered Lines: 1358
Relevant Lines: 2059

💛 - Coveralls

@Mister-Hope Mister-Hope requested a review from Copilot April 1, 2025 05:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new feature that integrates Meilisearch-based search functionality into the repo. Key changes include:

  • Definition of shared types for Meilisearch options.
  • Implementation of the VuePress plugin with both node and client configurations.
  • Setup of client components to render the search box.

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
plugins/search/plugin-meilisearch/src/shared/index.ts Added shared type definitions for Meilisearch options.
plugins/search/plugin-meilisearch/src/node/option.ts Introduced plugin options type alias based on shared types.
plugins/search/plugin-meilisearch/src/node/meiliSearchPlugin.ts Created the plugin definition for Meilisearch integration.
plugins/search/plugin-meilisearch/src/node/index.ts Re-exported plugin definitions (note a potential syntax issue).
plugins/search/plugin-meilisearch/src/client/config.ts Configured client enhancements using the defined search component.
plugins/search/plugin-meilisearch/src/client/components/index.ts Exported the MeiliSearch component.
plugins/search/plugin-meilisearch/src/client/components/MeiliSearch.ts Defined the MeiliSearch component and its behavior on mount.
plugins/search/plugin-meilisearch/rollup.config.ts Configured bundling for node and client code via Rollup.
Files not reviewed (4)
  • plugins/search/plugin-meilisearch/package.json: Language not supported
  • plugins/search/plugin-meilisearch/tsconfig.build.json: Language not supported
  • pnpm-lock.yaml: Language not supported
  • tsconfig.build.json: Language not supported

@Mister-Hope
Copy link
Member

Mister-Hope commented Apr 12, 2025

There is only 1 blocking things left:

Search results are not filtered by locales in your demo, and related docs are not updated either.

@JQiue Can you handle this?

@Mister-Hope Mister-Hope changed the title feat(plugin-meilisearch): add code to repo feat(plugin-meilisearch): support meilisearch Apr 12, 2025
@Mister-Hope Mister-Hope marked this pull request as draft April 12, 2025 15:06
@Mister-Hope

This comment was marked as outdated.

@Mister-Hope Mister-Hope marked this pull request as ready for review April 14, 2025 07:56
@Mister-Hope Mister-Hope merged commit 819fc11 into vuepress:main Apr 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants