fix: fix code block related style #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mister-Hope
requested review from
pengzhanbo and
Copilot
and removed request for
pengzhanbo
There was a problem hiding this comment.
Pull Request Overview
This PR unifies the code block styles in mobile view by standardizing padding, margins, transitions, and border radius values using theme-defined CSS variables. Key changes include updating transition properties, replacing hardcoded values with CSS variables, and removing redundant mobile media queries.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/highlighter-helper/src/client/styles/notation-highlight.scss | Added transition property for highlighted code lines using theme variables. |
| tools/highlighter-helper/src/client/styles/notation-diff.scss | Added transition property for diff lines to align with unified styling. |
| tools/highlighter-helper/src/client/styles/code-block-title.scss | Updated border radius and mobile margins to use CSS variables. |
| tools/highlighter-helper/src/client/styles/base.scss | Introduced margin adjustments and transition properties along with print media white-space handling. |
| themes/theme-default/src/client/styles/content/code.scss | Refactored code block styling within a [vp-content] scope and modified mobile styles. |
| plugins/markdown/plugin-revealjs/src/client/styles/reveal-js.scss | Removed redundant mobile view styling for reveal.js slides. |
| plugins/markdown/plugin-markdown-tab/src/client/styles/tabs.scss | Introduced a root variable for tab border radius and applied it to relevant elements. |
| plugins/markdown/plugin-markdown-tab/src/client/styles/code-tabs.scss | Updated border radius and dimension properties to use theme variables for consistency. |
Comments suppressed due to low confidence (2)
tools/highlighter-helper/src/client/styles/notation-highlight.scss:19
- Consider verifying that '--vp-t-color' contains a valid timing value for transitions; its name might be interpreted as a color variable, which could be misleading.
transition: background-color var(--vp-t-color);
plugins/markdown/plugin-markdown-tab/src/client/styles/code-tabs.scss:54
- Using '--code-border-radius' as a dimension for width and height might lead to unintended sizing if the variable is primarily intended for border radius; consider using a dedicated variable for sizing if necessary.
width: var(--code-border-radius);
Pull Request Test Coverage Report for Build 14900980297Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unified all styles that are related to the default theme
1.5rempadding in mobile view to theme default scope.