Skip to content

Conversation

pengzhanbo
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

I believe there is no need to set built-in theme variables in Mermaid, as the default styles are already quite excellent.

These built-in theme settings hinder users from customizing their styles.
Therefore, I think it is appropriate to remove them.

Using theme:dark directly in dark mode is more reasonable.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15698071657

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.616%

Totals Coverage Status
Change from base Build 15629644930: 0.0%
Covered Lines: 1420
Relevant Lines: 2092

💛 - Coveralls

@Mister-Hope Mister-Hope merged commit e211c68 into main Jun 17, 2025
30 checks passed
@Mister-Hope Mister-Hope deleted the chart-mermaid-style branch June 17, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants