Fix #34: Redirect to lang if dialect is not found #42
Conversation
This change means that users with browsers that send an unknow region of a known language will still be forwarded to the correct overall language. For example, users with a browser that sends `de-AT` as a locale will still be forwarded to the `de-DE` locale, as the plugin will only take the lowercase `de` into account while ignoring the region-specific uppercase `DE` and `AT`.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
- vuepress-types@0.9.2
- docs@1.0.11 - vuepress-plugin-container@2.1.4 - vuepress-plugin-dehydrate@1.1.4 - vuepress-plugin-named-chunks@1.1.3 - vuepress-plugin-nprogress@1.1.7 - vuepress-plugin-redirect@1.2.4 - vuepress-plugin-serve@2.0.3 - vuepress-plugin-table-of-contents@1.1.6 - vuepress-plugin-typescript@0.3.0 - vuepress-types@0.9.3
|
I can't wait any longer with this because it's fundamentally broken so I will just continue on a fork of vuepress-community myself. I am still happy to make a new pull request, please see the conversation in #34. |
|
Sorry I don't have so much time for open source projects these days. Feel free to create your own fork and thanks for your contribution~ |
|
@meteorlxy I totally understand that personal priorities shift but is there no one else from the Vue(Press) community who could potentially take over the maintenance of this package? I would consider it pretty important for VuePress and clearly there are still some issues with it that make it "less than ideal" for production. I am a bit frustrated because I never even got a response about what was wrong with my commit which is also why I never followed-up with the issue in #44 because that would take a lot of time to prepare even though it's reliably reproducible. Again, I consider this commit more of a bug fix and I even have Google Analytics data to back up this lack of redirects for many browsers. Anyway, my commit is still here now on a cleaned refork: |
|
In fact, this org is NOT officially maintained by VuePress team (even though I'm a member of the them).
In addition, you must know that most open source projects can not be guaranteed, because they don't have any sponsors and cannot help their authors to make a live. Just for the open source spirit！:smile: |
Summary
This change means that users with browsers that send an unknow region of
a known language will still be forwarded to the correct overall language.
For example, users with a browser that sends
de-ATas a localewill still be forwarded to the
de-DElocale, as the plugin willonly take the lowercase
deinto account while ignoringthe region-specific uppercase
DEandAT.Which package does this PR involve? (check one)
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)Other information:
#34