Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Conversation

ttskch
Copy link
Contributor

@ttskch ttskch commented Apr 30, 2020

Summary

I make ease to understand how to use getPaginationPageTitle option.

We cannot use ${entryTitle} in our own callback function. Using ${entryTitle} in our callback causes build error ReferenceError: entryTitle is not defined.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

https://vuepress-plugin-blog.ulivz.com/pagination/#getpaginationpagetitle

We cannot use `${entryTitle}` in our own callback function. Using `${entryTitle}` in our callback causes build error `ReferenceError: entryTitle is not defined`.
Copy link
Member

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@billyyyyy3320 billyyyyy3320 changed the title docs: Make ease to understand how to use getPaginationPageTitle docs: make ease to understand how to use getPaginationPageTitle May 3, 2020
@billyyyyy3320 billyyyyy3320 merged commit 5b685c3 into vuepress:master May 3, 2020
@ttskch ttskch deleted the patch-1 branch May 4, 2020 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants