Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: making the repository in the standard and bug fixes #8

Merged
merged 15 commits into from
Sep 8, 2022
Merged

fix: making the repository in the standard and bug fixes #8

merged 15 commits into from
Sep 8, 2022

Conversation

dead-playmod
Copy link

@dead-playmod dead-playmod commented Aug 30, 2022

Description

Makes this repository closer to standards, and fixes previous issues related to it.

This PR also has bug fixes not related to making this repository in VSF2 standards, and these are:

  • fixing cart not updating after page reload
  • fixing language switcher
  • fixing console error referring to promotion coupon
  • removing "terms and conditions" from checkout
  • removing "match it from" product page
  • fixing "add to cart" button on product category page
  • fixing login modal in checkout
  • fixing "my account" page
  • fixing autocomplete in checkout

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dead-playmod dead-playmod changed the title Standard chore: making the repository in the standard Aug 31, 2022
@dead-playmod dead-playmod changed the title chore: making the repository in the standard chore + fix: making the repository in the standard and bug fixes Sep 5, 2022
@dead-playmod dead-playmod changed the title chore + fix: making the repository in the standard and bug fixes fix: making the repository in the standard and bug fixes Sep 6, 2022
@senghe senghe merged commit 4414a32 into vuestorefront-community:standard Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants