Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sizes of images in related products component #172

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

AdamPawlinski
Copy link
Contributor

Description

Fixed sizes of images on Related Products component to be equal for mobile and desktop views.

Related Issue

#166

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, just remember to also update the changelog :)

For this kind of thing, I would recommend going for 1.2.0

@Baroshem Baroshem linked an issue Feb 18, 2022 that may be closed by this pull request
1 task
@Baroshem Baroshem merged commit bc333bd into develop Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong size of images in Related Products component
2 participants