feat: payment provider and customer step in checkout #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baroshem
changed the title
Baroshem
changed the title
Comment on lines
+16
to
+22
| const request = await context.client.mutate({ | ||
| mutation: gql`${setCustomerForOrder.query}`, | ||
| variables: setCustomerForOrder.variables, | ||
| fetchPolicy: NO_CACHE_FETCH_POLICY | ||
| }) as SetCustomerForOrderResponse; | ||
|
|
||
| return request; |
There was a problem hiding this comment.
You can simplify that.
Suggested change
| const request = await context.client.mutate({ | |
| mutation: gql`${setCustomerForOrder.query}`, | |
| variables: setCustomerForOrder.variables, | |
| fetchPolicy: NO_CACHE_FETCH_POLICY | |
| }) as SetCustomerForOrderResponse; | |
| return request; | |
| return await context.client.mutate({ | |
| mutation: gql`${setCustomerForOrder.query}`, | |
| variables: setCustomerForOrder.variables, | |
| fetchPolicy: NO_CACHE_FETCH_POLICY | |
| }) as SetCustomerForOrderResponse; |
Mateuszpietrusinski
approved these changes
Aug 25, 2021
Comment on lines
+14
to
+19
| const request = await context.client.query<RequestDataStructure<'eligiblePaymentMethods', PaymentMethodQuote[]>>({ | ||
| query: gql`${eligiblePaymentMethods.query}`, | ||
| variables: eligiblePaymentMethods.variables, | ||
| fetchPolicy: NO_CACHE_FETCH_POLICY | ||
| }); | ||
| return request; |
There was a problem hiding this comment.
Suggested change
| const request = await context.client.query<RequestDataStructure<'eligiblePaymentMethods', PaymentMethodQuote[]>>({ | |
| query: gql`${eligiblePaymentMethods.query}`, | |
| variables: eligiblePaymentMethods.variables, | |
| fetchPolicy: NO_CACHE_FETCH_POLICY | |
| }); | |
| return request; | |
| return await context.client.query<RequestDataStructure<'eligiblePaymentMethods', PaymentMethodQuote[]>>({ | |
| query: gql`${eligiblePaymentMethods.query}`, | |
| variables: eligiblePaymentMethods.variables, | |
| fetchPolicy: NO_CACHE_FETCH_POLICY | |
| }); |
Comment on lines
+21
to
+27
| const request = await context.client.mutate({ | ||
| mutation: gql`${addPaymentToOrder.query}`, | ||
| variables: addPaymentToOrder.variables, | ||
| fetchPolicy: NO_CACHE_FETCH_POLICY | ||
| }) as SetShippingMethodResponse; | ||
|
|
||
| return request; |
There was a problem hiding this comment.
Redundant variable
Suggested change
| const request = await context.client.mutate({ | |
| mutation: gql`${addPaymentToOrder.query}`, | |
| variables: addPaymentToOrder.variables, | |
| fetchPolicy: NO_CACHE_FETCH_POLICY | |
| }) as SetShippingMethodResponse; | |
| return request; | |
| return await context.client.mutate({ | |
| mutation: gql`${addPaymentToOrder.query}`, | |
| variables: addPaymentToOrder.variables, | |
| fetchPolicy: NO_CACHE_FETCH_POLICY | |
| }) as SetShippingMethodResponse; |
Comment on lines
+16
to
+22
| const request = await context.client.mutate({ | ||
| mutation: gql`${transitionOrderToState.query}`, | ||
| variables: transitionOrderToState.variables, | ||
| fetchPolicy: NO_CACHE_FETCH_POLICY | ||
| }) as TransitionOrderToState; | ||
|
|
||
| return request; |
There was a problem hiding this comment.
Suggested change
| const request = await context.client.mutate({ | |
| mutation: gql`${transitionOrderToState.query}`, | |
| variables: transitionOrderToState.variables, | |
| fetchPolicy: NO_CACHE_FETCH_POLICY | |
| }) as TransitionOrderToState; | |
| return request; | |
| return await context.client.mutate({ | |
| mutation: gql`${transitionOrderToState.query}`, | |
| variables: transitionOrderToState.variables, | |
| fetchPolicy: NO_CACHE_FETCH_POLICY | |
| }) as TransitionOrderToState; |
Comment on lines
+137
to
+142
| router: { | ||
| extendRoutes(routes) { | ||
| getRoutes(`${__dirname}/_theme`) | ||
| .forEach((route) => routes.unshift(route)); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Yes, I need to have a checkout flow start from customer not shipping and in order to do that I have to extend default routes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #56
Closes #57
I decided to release these two functionalities as one purely because payment wont work without customer step.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: