Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SfSelect): disabled state attributes [SFUI2-1307] #2947

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

jagoral
Copy link
Contributor

@jagoral jagoral commented Aug 7, 2023

Related issue

https://vsf.atlassian.net/browse/SFUI2-1307

Scope of work

Removed redundant selected attribute from SfSelect placeholder. It caused a warning: Warning: Use the defaultValue or value props on <select> instead of setting selected on <option>

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

🦋 Changeset detected

Latest commit: 7d851e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@storefront-ui/react Patch
@storefront-ui/vue Patch
@storefront-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jagoral jagoral force-pushed the fix--sf-select-placeholder-attributes branch from 216f8b5 to 1667e4f Compare August 7, 2023 08:45
@Szymon-dziewonski
Copy link
Contributor

Hey @jagoral thanks for contribution, however tests are failing so they need to be adjusted https://github.com/vuestorefront/storefront-ui/blob/e0b7224b1cb1bb51e65feb0e4ed5a03e8128c048/packages/tests/components/SfSelect/SfSelect.cy.tsx in line 102 change it into page().isNotDisabled().hasSelectedOption('blue'); should do the work :). Please let me know if you'll have any questions :)

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jagoral
Copy link
Contributor Author

jagoral commented Aug 7, 2023

@Szymon-dziewonski test fixed, thanks

@jagoral jagoral merged commit 3ef44b5 into v2-develop Aug 8, 2023
112 checks passed
@jagoral jagoral deleted the fix--sf-select-placeholder-attributes branch August 8, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants