-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SfSelect): disabled state attributes [SFUI2-1307] #2947
Conversation
🦋 Changeset detectedLatest commit: 7d851e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
216f8b5
to
1667e4f
Compare
Hey @jagoral thanks for contribution, however tests are failing so they need to be adjusted https://github.com/vuestorefront/storefront-ui/blob/e0b7224b1cb1bb51e65feb0e4ed5a03e8128c048/packages/tests/components/SfSelect/SfSelect.cy.tsx in line 102 change it into |
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
1 similar comment
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
@Szymon-dziewonski test fixed, thanks |
Related issue
https://vsf.atlassian.net/browse/SFUI2-1307
Scope of work
Removed redundant
selected
attribute fromSfSelect
placeholder. It caused a warning: Warning: Use the defaultValue or value props on<select>
instead of setting selected on<option>
Screenshots of visual changes
Checklist