Feature-test/mchtctn-nuc116-label-component #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 6, 2019 11:45
…ture-test/mchtctn-nuc116-labelComponent
mchtctn
changed the title
added 2 commits
May 13, 2019 11:10
Codecov Report
@@ Coverage Diff @@
## integration/v0.3.0 #67 +/- ##
===================================================
Coverage 92.53% 92.53%
===================================================
Files 37 37
Lines 415 415
Branches 82 82
===================================================
Hits 384 384
Misses 26 26
Partials 5 5Continue to review full report at Codecov.
|
osmanertem
previously approved these changes
May 13, 2019
ercang
previously approved these changes
May 14, 2019
| before: function(client, done) { | ||
| this.currentPage = client.maximizeWindow().page.labelPage(); | ||
| this.currentPage | ||
| .navigate('http://localhost:8080/components/label.html') |
There was a problem hiding this comment.
can we set domain in a shared variable? 'localhost:8080' might change in the future
There was a problem hiding this comment.
domain set in globals.js
ercang
previously approved these changes
May 14, 2019
osmanertem
previously approved these changes
May 14, 2019
mylmz10
previously approved these changes
May 14, 2019
mylmz10
previously approved these changes
May 14, 2019
ercang
previously approved these changes
May 14, 2019
osmanertem
approved these changes
May 14, 2019
osmanertem
previously approved these changes
May 14, 2019
aylino
changed the title
esracaglar
previously approved these changes
May 16, 2019
ahmetceylan
dismissed stale reviews from esracaglar, osmanertem, ercang, and mylmz10
via
42b9efb
mchtctn
changed the title
aylino
approved these changes
May 22, 2019
esracaglar
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.