This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Correctly parse uint8 values in contract watcher #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmulhol
commented
Sep 21, 2019
rmulhol
commented
- calling string(uint8) => insert errors on numeric columns
- calling string(uint8) => insert errors on numeric columns
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
elizabethengelman
approved these changes
Sep 23, 2019
| @@ -89,9 +89,9 @@ func (c *Converter) Convert(logs []gethTypes.Log, event types.Event, headerID in | |||
| if len(b) == 32 { | |||
| seenHashes = append(seenHashes, common.HexToHash(strValues[fieldName])) | |||
| } | |||
| case byte: | |||
| b := input.(byte) | |||
| strValues[fieldName] = string(b) | |||
There was a problem hiding this comment.
Is there any need to keep this case byte in here as well? 🤔
There was a problem hiding this comment.
I don't think so - byte is an alias for uint8, so I could probably leave that as the name for this case if that seems clearer
There was a problem hiding this comment.
Gotcha. I like this case as uint8, it makes the type check on the next line make more sense to me.
i-norden
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.