This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Correctly identify missing headers after contract watcher restart #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
rmulhol
changed the title
rmulhol
force-pushed
the
contract-watcher-missing-headers
branch
from
d62fae6
to
3ad0101
Compare
i-norden
approved these changes
Sep 23, 2019
- Previously, we required that the first missing header match the configured starting block number. This helps guarantee that we have the necessary data for method polling in memory, but prevents the process from moving forward if restarted after the starting block has already been checked.
rmulhol
force-pushed
the
contract-watcher-missing-headers
branch
from
3ad0101
to
c21c069
Compare
yaoandrew
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #142
Note: built on top of #139 - will need to rebase after that's merged for a proper diff.