avoid UB in sinfl_bsr #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinfl_bsr
has undefined behavior for compilers other than MSVC, GCC and clang (in my case Tiny C Compiler) because the function won't return anything at all.I turned the
#elif
into a#else
so on compilers other than MSVC sinfl_bsr will always rely on__builtin_clz
. This can still cause a compile error on compilers that don't support __builtin_clz but at least we have a explicit error. Alternatively I could also implement sinfl_bsr by hand:I got this code from https://github.com/TinyCC/tinycc/blob/6ec4a106524ab6a6e3a4178774fd1e884d3fcce2/lib/builtin.c#L50