Skip to content

Conversation

izgzhen
Copy link
Contributor

@izgzhen izgzhen commented Jul 11, 2016

There are several small fixes, and I'd like to discuss about these changes (and improve it if necessary) before some of them are applied.

line 400: I suppose that it is not clear about what does "ignore" here mean, so I emphasize its motivation.

line 500 and related: I moved one note after the Attributes section of Blob and another note duplicated in two places just below the type attribute definition since the two notes are both type-related.

For the duplicated note, I deleted its appearance in two other algorithm descriptions because this note addresses what does "parsable MIME type" mean, while the two algorithms don't refer to that particular definition. So I think it is more proper to put it under type attribute definition (in which "parsable MIME type" is referred).

Also, I rewrote this note in a more readable form as I suppose.

line 520: upto is a typo as I suppose.

line 610: I rewrote description of close() a more readable form as I suppose.

@izgzhen
Copy link
Contributor Author

izgzhen commented Jul 11, 2016

Not very clear about what to do with .html and the failed check (Is this related to https://github.com/w3c/FileAPI/blob/gh-pages/CONTRIBUTING.md ?)

The <dfn id="dfn-close" method for=Blob>close()</dfn> method is said to <a lt="closed" for=Blob>close</a> a {{Blob}},
and must act as follows on the {{Blob}} on which the method has been called:
The <dfn id="dfn-close" method for=Blob>close()</dfn> method is said to <a lt="closed" for=Blob>close</a>
the {{Blob}} context object when it acts on the {{Blob}} as follows:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this rephrasing, in particular using "when" to combine the two sentence fragments sounds wrong to me (but I'm not a native english speaker). I'd rather just get rid of the whole "on the {{Blob}} on which the method has been called" part, but otherwise keep the current text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for dropping it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mkruisselbrink
Copy link
Collaborator

Not very clear about what to do with .html and the failed check (Is this related to https://github.com/w3c/FileAPI/blob/gh-pages/CONTRIBUTING.md ?)

It's fine to leave updating the .html to me. Not sure what's up with the CLA check either. This change is probably non-substantive enough for that not too matter too much, but I'm not sure what the check exactly is trying to say and what to do about it either.

@mkruisselbrink mkruisselbrink merged commit c63a84b into w3c:gh-pages Aug 17, 2016
@dontcallmedom
Copy link
Member

Marked as non-substantive for IPR from ash-nazg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants