-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JumpTo: can't scroll to bottom of menu if not fully visible in viewport #134
Comments
I am also seeing that issue. A suggestion for a temporary fix is to amend the following CSS to the menu container:
The first style should keep the entire container within the viewport. The second should make the container itself scroll. |
For info, saw it in chrome, Version 101.0.4951.67 |
Are we pulling the jumpto script from the aria-practices repo? Or, is it living in wai-aria-practices? I just want this issue in the same repo where the PR will be made. I don't see it in the scripts directory in aria-practices. |
Here is a an update to the SkipTo.js script to use the scripted shortcut instead of the HTML https://github.com/paypal/skipto/tree/dev/v4.2/downloads/js As per the conversation today, the APG will just switch from using "JumpTo" to using "SkipTo" to eliminate the need to maintain two separate code repositories and make it easier for other people to add the "SkipTo" functionality to their website. |
Not privy to the APG call — is the plan for fixing this issue going to address the container height and overflow, or is this control being completely replaced? |
The update uses container height and overflow to fix the content overflow issue. JumpTo is a one off of the SkipTo code, so this is an attempt to harmonize the divergent branches and just use the more established SkipTo for deployment, |
Gotcha. Thanks for the explanation. |
Note : please create another ticket if you feel that it is relevant. And sorry for my English. I am checking the menu to remember a bit the issue and I realize that the items in the jump menu are not coded as links and therefore:
So basically, it seems to me that that items of the jump menu do not respect 1.3.1 and 2.1.1 WCAG criterias |
SkipTo is implementing the ARIA menu button pattern and the use of the menu roles provides screen reader users with information that they can use the cursor keys for navigation of the menu items. If link roles were used, screen reader users would assume that they would need to use the Tab key to move between items. If you feel that this is not an appropriate use of the menu button pattern, you should file an issue with the ARIA authoring practices. I am not sure what your second point means, I guess I need clarification on the issue. |
I think there are two main points here.
|
thanks, I will check that. Thanks a lot for your time and you precious answers. |
* Correct copyright and license to accurately attribute authorship and source * Fix #133: skip to menu label incorrect on Mac * Fix #134: can't scroll to bottom of skip to menu if not fully visible in viewport * Fix #135: skip to main does not work on Home Page by ensuring target of skip is visible. Co-authored-by: Matt King <a11yThinker@gmail.com> Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
on the page of the patterns, we can access to to a menu by clicking on "alt" + "0". The issues is that it is hard to scroll on the menu: the menu is bigger than my screen and I can't scroll to see the bottom menu items because I am always send it back to the top of the menu.
The text was updated successfully, but these errors were encountered: