Change aria-hidden=false to synonym of undefined #2090

scottaohara · 2023-12-14T17:04:17Z

resolves #1256

This PR modifies the previous note about aria-hidden=false to instead indicate that as of ARIA 1.3 is serves as a synonym for the 'undefined' value.

It also includes a minor editorial change to remove the mention of 'screen readers' from the last paragraph of the normative text. It seemed to state, especially when the sentence ends with referring to 'assistive technologies' in general.

See last comment

Question: assuming this PR is approved, would we also want to add the following sentence to the note?

In future versions of ARIA, the undefined value will be deprecated in favor of the false value.

PR tracking

Check these when the relevant issue or PR has been made, OR after you have confirmed the
related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the
Process Document or
Test Overview for more information.

Related Core AAM Issue/PR: N/A
Related AccName Issue/PR: N/A
Related APG Issue/PR: N/A
Any other dependent changes? N/A
- WPT tests (multiple implementations passing before merge)

Implementation tracking

"author MUST" tests: N/A
"user agent MUST" tests
- Tests for removal of aria-hidden=false web-platform-tests/interop-accessibility#88
Browser implementations (link to issue or when done, link to commit):
- WebKit: https://webkit.org/b/267150
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1880579
- Blink: https://bugs.chromium.org/p/chromium/issues/detail?id=1500299
Does this need AT implementations? No

Preview | Diff

resolves #1256 This PR modifies the previous note about aria-hidden=false to instead indicate that as of ARIA 1.3 is serves as a synonym for the 'undefined' value. It also includes a minor editorial change to remove the mention of 'screen readers' from the last paragraph of the normative text. It seemed to state, especially when the sentence ends with referring to 'assistive technologies' in general. See [last comment](#1256 (comment)) Chrome issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1500299 Question: assuming this PR is approved, would we also want to add the following sentence to the note? >In future versions of ARIA, the undefined value will be deprecated in favor of the false value.

index.html

cookiecrook

@aleventhal approved this PR, but he was also proposing that aria-hidden=false be allowed on visibly rendered items, a partial equivalent to the inert attribute. What changed, Aaron?

If there's a possibility we'll ever want to bring this value back, we should not change it now, and instead wait to change it once WICG/aom#203 (or some other testing approach) gives us access to inspect whether the node is "hidden from accessibility"

cookiecrook · 2024-01-05T02:29:44Z

@jnurthen there were other related issues in the ARIA-hidden project that have been moved elsewhere. Should a keyword be added instead? Is there an easy way to find those issues? I'm not sure why they were put in a 1.3/1.4 Projects when we already had 1.3/1.4 Milestones. Apologies if that explanation was covered in one of the meetings I missed.

aleventhal · 2024-01-05T15:24:51Z

@aleventhal approved this PR, but he was also proposing that aria-hidden=false be allowed on visibly rendered items, a partial equivalent to the inert attribute. What changed, Aaron?

I wanted aria-hidden="false" to be useful, but unfortunately, as was pointed out to me, it's misused by a lot of JS toolkits which treat it as a boolean, and they end up setting "false" all over the place where they really should have removed the attribute.

If there's a possibility we'll ever want to bring this value back, we should not change it now, and instead wait to change it once WICG/aom#203 (or some other testing approach) gives us access to inspect whether the node is "hidden from accessibility"

Because of the problem in js toolkits, and because browsers all implement it differently, I think we should go ahead and deprecate it as a possible value.

cookiecrook · 2024-01-05T20:54:25Z

Because of the problem in js toolkits, and because browsers all implement it differently, I think we should go ahead and deprecate [aria-hidden=false] as a possible value.

Okay. I'm going to ask @twilco and @minorninth to review as well in case there are implementation concerns with its removal.

I'm hopeful it goes without saying that this should not be merged until we have extensively passing WPT tests. Since this one wasn't in the initial Interop 2024 Focus Area proposal, that may not happen this year, but we can treat it as a tentative area for inclusion if there is time to fix it before the Fall releases.

cookiecrook

Updating my "Changes Requested" review to "Comment" tentatively pending review from others.

cookiecrook

Second time's the charm?

Aaron answered pending questions.

index.html

minorninth · 2024-01-08T05:05:10Z

I support removing the semantics of aria-hidden=false, but I'd like to improve the wording. I left some comments. Thanks.

Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>

index.html

SHA: 6205740 Reason: push, by jnurthen Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

MrHBS · 2024-05-02T22:03:29Z

index.html

 				<p class="note">Authors are advised to use extreme caution and consider a wide range of disabilities when hiding visibly rendered content from assistive technologies. For example, a sighted, dexterity-impaired individual might use voice-controlled assistive technologies to access a visual interface. If an author hides visible link text "Go to checkout" and exposes similar, yet non-identical link text "Check out now" to the accessibility API, the user might be unable to access the interface they perceive using voice control. Similar problems can also arise for screen reader users. For example, a sighted telephone support technician might attempt to have the blind screen reader user click the "Go to checkout" link, which they might be unable to find using a type-ahead item search ("Go to…").</p>
-				<p class="note">At the time of this writing, <code><sref>aria-hidden</sref>="false"</code> is known to work inconsistently in browsers. As future implementations improve, use caution and test thoroughly before relying on this approach.</p>
+				<p class="note">As of ARIA 1.3, <code><sref>aria-hidden</sref>="false"</code> is now synonymous with <code>aria=hidden="undefined"</code>.</p>


nit: aria-hidden*

https://bugs.webkit.org/show_bug.cgi?id=277958 rdar://problem/133693990 Reviewed by NOBODY (OOPS!). Per spec changes (see w3c/aria#2090), we should treat `aria-hidden=false` as undefined. This patch removes support for aria-hidden=false, updating places where we relied on the behaviors of isNodeARIAVisible with the new behavior. For example, we need to check if a child node is focused before deciding whether to skip it if it is aria-hidden (tested by accessibility/datetime/input-date-field-labels-and-value-changes.html). Tests that explicitly validate aria-hidden false were removed, and a new test to check that we are ignoring this property has been added. * LayoutTests/accessibility/aria-hidden-false-ignored-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-false-ignored.html: Added. * LayoutTests/accessibility/aria-hidden-false-works-in-subtrees.html: Removed. * LayoutTests/accessibility/aria-hidden-negates-no-visibility.html: Removed. * LayoutTests/accessibility/aria-modal-expected.txt: * LayoutTests/accessibility/aria-modal.html: * LayoutTests/accessibility/aria-visible-element-roles.html: Removed. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::isNodeVisible const): (WebCore::AXObjectCache::getOrCreate): (WebCore::isNodeFocused): (WebCore::isNodeAriaVisible): Deleted. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::textUnderElement const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addNodeOnlyChildren):

https://bugs.webkit.org/show_bug.cgi?id=277958 rdar://problem/133693990 Reviewed by NOBODY (OOPS!). Per spec changes (see w3c/aria#2090), we should treat `aria-hidden=false` as undefined. This patch removes support for aria-hidden=false, updating places where we relied on the behaviors of isNodeARIAVisible with the new behavior. For example, we need to check if a child node is focused before deciding whether to skip it if it is aria-hidden (tested by accessibility/datetime/input-date-field-labels-and-value-changes.html). Tests that explicitly validate aria-hidden false were removed, and a new test to check that we are ignoring this property has been added. * LayoutTests/accessibility/aria-hidden-false-ignored-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-false-ignored.html: Added. * LayoutTests/accessibility/aria-hidden-false-works-in-subtrees.html: Removed. * LayoutTests/accessibility/aria-hidden-negates-no-visibility.html: Removed. * LayoutTests/accessibility/aria-modal-expected.txt: * LayoutTests/accessibility/aria-modal.html: * LayoutTests/accessibility/aria-visible-element-roles.html: Removed. * LayoutTests/accessibility/datetime/input-date-field-labels-and-value-changes.html: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::isNodeVisible const): (WebCore::AXObjectCache::getOrCreate): (WebCore::isNodeFocused): (WebCore::isNodeAriaVisible): Deleted. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::textUnderElement const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addNodeOnlyChildren):

https://bugs.webkit.org/show_bug.cgi?id=277958 rdar://problem/133693990 Reviewed by NOBODY (OOPS!). Per spec changes (see w3c/aria#2090), we should treat `aria-hidden=false` as undefined. This patch removes support for aria-hidden=false, updating places where we relied on the behaviors of isNodeARIAVisible with the new behavior. For example, we need to check if a child node is focused before deciding whether to skip it if it is aria-hidden (tested by accessibility/datetime/input-date-field-labels-and-value-changes.html). Tests that explicitly validate aria-hidden false were removed, and a new test to check that we are ignoring this property has been added. * LayoutTests/accessibility/aria-hidden-false-ignored-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-false-ignored.html: Added. * LayoutTests/accessibility/aria-hidden-false-works-in-subtrees.html: Removed. * LayoutTests/accessibility/aria-hidden-negates-no-visibility.html: Removed. * LayoutTests/accessibility/aria-hidden-subtree-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-subtree.html: Added. * LayoutTests/accessibility/aria-modal-expected.txt: * LayoutTests/accessibility/aria-modal.html: * LayoutTests/accessibility/aria-visible-element-roles.html: Removed. * LayoutTests/accessibility/datetime/input-date-field-labels-and-value-changes.html: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::isNodeVisible const): (WebCore::AXObjectCache::getOrCreate): (WebCore::isNodeFocused): (WebCore::isNodeAriaVisible): Deleted. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::textUnderElement const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addNodeOnlyChildren):

https://bugs.webkit.org/show_bug.cgi?id=267150 rdar://120557669 Reviewed by NOBODY (OOPS!). Per spec changes (see w3c/aria#2090), we should treat `aria-hidden=false` as undefined. This patch removes support for aria-hidden=false, updating places where we relied on the behaviors of isNodeARIAVisible with the new behavior. For example, we need to check if a child node is focused before deciding whether to skip it if it is aria-hidden (tested by accessibility/datetime/input-date-field-labels-and-value-changes.html). Tests that explicitly validate aria-hidden false were removed, and a new test to check that we are ignoring this property has been added. * LayoutTests/accessibility/aria-hidden-false-ignored-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-false-ignored.html: Added. * LayoutTests/accessibility/aria-hidden-false-works-in-subtrees.html: Removed. * LayoutTests/accessibility/aria-hidden-negates-no-visibility.html: Removed. * LayoutTests/accessibility/aria-hidden-subtree-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-subtree.html: Added. * LayoutTests/accessibility/aria-modal-expected.txt: * LayoutTests/accessibility/aria-modal.html: * LayoutTests/accessibility/aria-visible-element-roles.html: Removed. * LayoutTests/accessibility/datetime/input-date-field-labels-and-value-changes.html: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::isNodeVisible const): (WebCore::AXObjectCache::getOrCreate): (WebCore::isNodeFocused): (WebCore::isNodeAriaVisible): Deleted. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::textUnderElement const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addNodeOnlyChildren):

https://bugs.webkit.org/show_bug.cgi?id=267150 rdar://120557669 Reviewed by NOBODY (OOPS!). Per spec changes (see w3c/aria#2090), we should treat `aria-hidden=false` as undefined. This patch removes support for aria-hidden=false, updating places where we relied on the behaviors of isNodeARIAVisible with the new behavior. For example, we need to check if a child node is focused before deciding whether to skip it if it is aria-hidden (tested by accessibility/datetime/input-date-field-labels-and-value-changes.html). Tests that explicitly validate aria-hidden false were removed, and a new test to check that we are ignoring this property has been added. * LayoutTests/accessibility/aria-hidden-false-ignored-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-false-ignored.html: Added. * LayoutTests/accessibility/aria-hidden-false-works-in-subtrees.html: Removed. * LayoutTests/accessibility/aria-hidden-negates-no-visibility.html: Removed. * LayoutTests/accessibility/aria-hidden-subtree-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-subtree.html: Added. * LayoutTests/accessibility/aria-modal-expected.txt: * LayoutTests/accessibility/aria-modal.html: * LayoutTests/accessibility/aria-visible-element-roles.html: Removed. * LayoutTests/accessibility/datetime/input-date-field-labels-and-value-changes.html: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::isNodeVisible const): (WebCore::AXObjectCache::getOrCreate): (WebCore::isNodeFocused): (WebCore::isNodeAriaVisible): Deleted. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::textUnderElement const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addNodeOnlyChildren):

https://bugs.webkit.org/show_bug.cgi?id=267150 rdar://120557669 Reviewed by Tyler Wilcock. Per spec changes (see w3c/aria#2090), we should treat `aria-hidden=false` as undefined. This patch removes support for aria-hidden=false, updating places where we relied on the behaviors of isNodeARIAVisible with the new behavior. For example, we need to check if a child node is focused before deciding whether to skip it if it is aria-hidden (tested by accessibility/datetime/input-date-field-labels-and-value-changes.html). Tests that explicitly validate aria-hidden false were removed, and a new test to check that we are ignoring this property has been added. * LayoutTests/accessibility/aria-hidden-false-ignored-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-false-ignored.html: Added. * LayoutTests/accessibility/aria-hidden-false-works-in-subtrees.html: Removed. * LayoutTests/accessibility/aria-hidden-negates-no-visibility.html: Removed. * LayoutTests/accessibility/aria-hidden-subtree-expected.txt: Added. * LayoutTests/accessibility/aria-hidden-subtree.html: Added. * LayoutTests/accessibility/aria-modal-expected.txt: * LayoutTests/accessibility/aria-modal.html: * LayoutTests/accessibility/aria-visible-element-roles.html: Removed. * LayoutTests/accessibility/datetime/input-date-field-labels-and-value-changes.html: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::isNodeVisible const): (WebCore::AXObjectCache::getOrCreate): (WebCore::isNodeFocused): (WebCore::isNodeAriaVisible): Deleted. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::textUnderElement const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addNodeOnlyChildren): Canonical link: https://commits.webkit.org/284905@main

aleventhal approved these changes Dec 14, 2023

View reviewed changes

jnurthen requested review from cookiecrook and jcsteh December 14, 2023 18:08

jcsteh approved these changes Dec 15, 2023

View reviewed changes

scottaohara commented Dec 15, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

4a2d620

cookiecrook previously requested changes Jan 5, 2024

View reviewed changes

cookiecrook reviewed Jan 5, 2024

View reviewed changes

cookiecrook self-requested a review January 5, 2024 20:56

cookiecrook reviewed Jan 5, 2024

View reviewed changes

cookiecrook mentioned this pull request Jan 5, 2024

Tests for removal of aria-hidden=false web-platform-tests/interop-accessibility#88

Open

minorninth reviewed Jan 8, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

minorninth reviewed Jan 8, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

557d5b7

Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>

scottaohara commented Jan 8, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

364c15c

cookiecrook mentioned this pull request Jan 11, 2024

Consider allowing aria-hidden=false on visibly rendered elements inside an ancestor with aria-hidden=true #1256

Closed

cookiecrook approved these changes Jan 11, 2024

View reviewed changes

scottaohara commented Feb 5, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

adampage mentioned this pull request Feb 25, 2024

Clarify relationship between aria-hidden and aria-owns #1839

Open

Update index.html

6b47058

jnurthen merged commit 6205740 into main May 2, 2024
5 checks passed

github-actions bot added a commit that referenced this pull request May 2, 2024

Change aria-hidden=false to synonym of undefined (#2090)

d7ef906

SHA: 6205740 Reason: push, by jnurthen Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

MrHBS reviewed May 2, 2024

View reviewed changes

rahimabdi mentioned this pull request May 5, 2024

Clarify "undefined" assignment for a state/property as the value (not the string) #2177

Open

hoffmanjoshua mentioned this pull request Aug 12, 2024

AX: aria-hidden=false should be a synonym of undefined WebKit/WebKit#32044

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change aria-hidden=false to synonym of undefined #2090

Change aria-hidden=false to synonym of undefined #2090

scottaohara commented Dec 14, 2023 •

edited by pr-preview bot

Loading

cookiecrook left a comment •

edited

Loading

cookiecrook commented Jan 5, 2024 •

edited

Loading

aleventhal commented Jan 5, 2024

cookiecrook commented Jan 5, 2024

cookiecrook left a comment

cookiecrook left a comment •

edited

Loading

minorninth commented Jan 8, 2024

MrHBS May 2, 2024

Change aria-hidden=false to synonym of undefined #2090

Change aria-hidden=false to synonym of undefined #2090

Conversation

scottaohara commented Dec 14, 2023 • edited by pr-preview bot Loading

PR tracking

Implementation tracking

cookiecrook left a comment • edited Loading

Choose a reason for hiding this comment

cookiecrook commented Jan 5, 2024 • edited Loading

aleventhal commented Jan 5, 2024

cookiecrook commented Jan 5, 2024

cookiecrook left a comment

Choose a reason for hiding this comment

cookiecrook left a comment • edited Loading

Choose a reason for hiding this comment

minorninth commented Jan 8, 2024

MrHBS May 2, 2024

Choose a reason for hiding this comment

scottaohara commented Dec 14, 2023 •

edited by pr-preview bot

Loading

cookiecrook left a comment •

edited

Loading

cookiecrook commented Jan 5, 2024 •

edited

Loading

cookiecrook left a comment •

edited

Loading