Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Update computation step "comp_embedded_control" (formerly step 2c) text for clarity #2299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented Jul 31, 2024

Closes accname issue 244

If merged, this PR updates step "comp_embedded_control" (formerly step 2c) to be the agreed upon text per this issue: w3c/accname#244

If merged, this PR updates step 2C to be the agreed upon text per this issue: w3c/accname#244
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 03a72ef
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66aaa119e7480700087f23da
😎 Deploy Preview https://deploy-preview-2299--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MelSumner MelSumner added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:accname labels Jul 31, 2024
@MelSumner MelSumner changed the title Update index.html Update computation step 2c text for clarity Jul 31, 2024
@MelSumner MelSumner changed the title Update computation step 2c text for clarity [accname] Update computation step 2c text for clarity Aug 8, 2024
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a control embedded within the label
(e.g. any element directly referenced by <code>aria-labelledby</code>) for another <a class="termref">widget</a>, where the user can adjust the embedded control's value, then return
the embedded control as part of the text alternative in the following manner:
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-adjustable control embedded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"user-adjustable" doesn't account for an embedded readonly field.

Do we care about this?

<label for=""cb>
  <input type="cb" name="cb" id="id">
  Flash the screen <input readonly value="3"> times.
</label>

Will the new language, the (admittedly contrived) label above would be " Flash the screen times."

Copy link
Contributor

@cookiecrook cookiecrook Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I guess the old text doesn't account for readonly fields either.

…where the user can adjust the embedded control's value…

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"user-perceivable" perhaps?

Suggested change
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-adjustable control embedded
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-perceivable control embedded

Or just remove that adjective?

Copy link
Contributor

@cookiecrook cookiecrook Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This new proposed language would bring in disabled fields too, but I think that'd be expected if a disabled control were inside a label. What do you all think about this (also contrived) example?

<label for=""cb>
  <input type="cb" name="cb" id="id">
  Flash the screen <input disabled value="3"> times.
</label>

(e.g. any element directly referenced by <code>aria-labelledby</code>) for another <a class="termref">widget</a>, where the user can adjust the embedded control's value, then return
the embedded control as part of the text alternative in the following manner:
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-adjustable control embedded
within the label, and the control is not the element being named or described, then return the embedded control's value as part of the text alternative in the following manner:
Copy link
Contributor

@cookiecrook cookiecrook Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: take or leave. "as part of the text alternative" kinda makes it sound like you're overriding how this returned value would be included in the overall text alternative computation... I think the sentence stands without that clause, but feel free to keep it and resolve this comment if you disagree.

Suggested change
within the label, and the control is not the element being named or described, then return the embedded control's value as part of the text alternative in the following manner:
within the label, and the control is not the element being named or described, then return the embedded control's value in the following manner:

@accdc
Copy link
Contributor

accdc commented Aug 8, 2024

Simply referring to control sounds good to me if it's clear to everyone else.

@scottaohara
Copy link
Member

the argument about just saying "control" is that a display none control's value should not participate. and i'd also argue that one should not anticipate a input type=checkbox value=nope would have its value participate either.

a non-hidden control with a user-perceivable value (e.g., text input value or chosen option from a select, but not checkbox or radio button value) seems more like what we would actually want covered here.

@cookiecrook
Copy link
Contributor

a non-hidden control with a user-perceivable value (e.g., text input value or chosen option from a select, but not checkbox or radio button value) seems more like what we would actually want covered here.

"user-perceivable value" for a checkbox (true or false, checked or unchecked) would also be perceivable. If that's the case, the value for each control type would need to be specified. Yuck.

Should it be limited this to "user-perceivable control with a string value"?

@scottaohara
Copy link
Member

when i was referring to value i meant the string value. e.g., input type=checkbox value=foo the state (checked or not) shouldn't be considered as part of the calculation. agreed that'd be yucky.

@spectranaut spectranaut changed the title [accname] Update computation step 2c text for clarity Update computation step 2c text for clarity Aug 19, 2024
@spectranaut spectranaut changed the title Update computation step 2c text for clarity Editorial: Update computation step 2c text for clarity Aug 19, 2024
@cookiecrook cookiecrook changed the title Editorial: Update computation step 2c text for clarity Editorial: Update computation step "comp_embedded_control" (formerly step 2c) text for clarity Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:accname
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Computation steps, section 2C could be more clear
5 participants