-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Update computation step "comp_embedded_control" (formerly step 2c) text for clarity #2299
base: main
Are you sure you want to change the base?
Conversation
If merged, this PR updates step 2C to be the agreed upon text per this issue: w3c/accname#244
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a control embedded within the label | ||
(e.g. any element directly referenced by <code>aria-labelledby</code>) for another <a class="termref">widget</a>, where the user can adjust the embedded control's value, then return | ||
the embedded control as part of the text alternative in the following manner: | ||
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-adjustable control embedded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"user-adjustable" doesn't account for an embedded readonly
field.
Do we care about this?
<label for=""cb>
<input type="cb" name="cb" id="id">
Flash the screen <input readonly value="3"> times.
</label>
Will the new language, the (admittedly contrived) label above would be " Flash the screen times."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I guess the old text doesn't account for readonly
fields either.
…where the user can adjust the embedded control's value…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"user-perceivable" perhaps?
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-adjustable control embedded | |
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-perceivable control embedded |
Or just remove that adjective?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This new proposed language would bring in disabled
fields too, but I think that'd be expected if a disabled control were inside a label. What do you all think about this (also contrived) example?
<label for=""cb>
<input type="cb" name="cb" id="id">
Flash the screen <input disabled value="3"> times.
</label>
(e.g. any element directly referenced by <code>aria-labelledby</code>) for another <a class="termref">widget</a>, where the user can adjust the embedded control's value, then return | ||
the embedded control as part of the text alternative in the following manner: | ||
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-adjustable control embedded | ||
within the label, and the control is not the element being named or described, then return the embedded control's value as part of the text alternative in the following manner: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: take or leave. "as part of the text alternative" kinda makes it sound like you're overriding how this returned value would be included in the overall text alternative computation... I think the sentence stands without that clause, but feel free to keep it and resolve this comment if you disagree.
within the label, and the control is not the element being named or described, then return the embedded control's value as part of the text alternative in the following manner: | |
within the label, and the control is not the element being named or described, then return the embedded control's value in the following manner: |
Simply referring to control sounds good to me if it's clear to everyone else. |
the argument about just saying "control" is that a display none control's value should not participate. and i'd also argue that one should not anticipate a a non-hidden control with a user-perceivable value (e.g., text input value or chosen option from a select, but not checkbox or radio button value) seems more like what we would actually want covered here. |
"user-perceivable value" for a checkbox (true or false, checked or unchecked) would also be perceivable. If that's the case, the value for each control type would need to be specified. Yuck. Should it be limited this to "user-perceivable control with a string value"? |
when i was referring to value i meant the string value. e.g., |
Closes accname issue 244
If merged, this PR updates step "comp_embedded_control" (formerly step 2c) to be the agreed upon text per this issue: w3c/accname#244