Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Translatable Attributes section #906

Merged
merged 4 commits into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@jnurthen
Copy link
Contributor

jnurthen commented Feb 20, 2019

Resolves #755


Preview | Diff

@joanmarie

This comment has been minimized.

Copy link
Contributor

joanmarie commented Feb 21, 2019

The section looks fine.

Nit 1: I think it would make more sense to locate the section outside of 6.2. Functionally, it is an aspect of 6.3 (Values for States and Properties) because for those four properties, the value should be translated. So I'd put it under 6.3 (either as 6.3.1 or making it 6.4).

Nit 2: We're using "States and Properties" rather than "Attributes" for all headings in Section 6 (modulo 6.5.x for some reason). Therefore would it make sense to rename the new section "Translatable States and Properties" or "Translatable State and Property Values"?

@jnurthen jnurthen added the Agenda label Mar 6, 2019

@jnurthen

This comment has been minimized.

Copy link
Contributor Author

jnurthen commented Mar 21, 2019

Update to reference HTML spec

@mcking65
Copy link
Contributor

mcking65 left a comment

LGTM; just have one minor editorial suggestion.

index.html Outdated
@@ -8499,6 +8499,16 @@ <h3>Value</h3>
<h2>Values for States and Properties</h2>
<p>Many <a>states</a> and <a>properties</a> accept a specific set of tokens as <span>values</span>. The allowed values and explanation of their meaning is shown after the table of characteristics. The default value, if defined, is shown in <strong>strong</strong> type, followed by the parenthetical term 'default'. When a value is indicated as the default, the user agent MUST follow the behavior prescribed by this value when the state or property is empty or unspecified. Some <a>roles</a> also define what behavior to use when certain states or properties, that do not have default values, are not provided.</p>
</section>
<section>
<h2>Translatable States and Properties</h2>
<p>The values of the following <a>states</a> and <a>properties</a> should be translated when a page is localized:</p>

This comment has been minimized.

Copy link
@mcking65

mcking65 Mar 21, 2019

Contributor

Perhaps:

In order to be understandable by assistive technology users, the values of the following states and properties need to be translated when a page is localized:

This revision:

  1. clarifies the reason for translation.
  2. Avoids normative sounding language when there is no clear subject for a normative requirement.

@jnurthen jnurthen merged commit f45587f into master Mar 27, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ipr PR deemed acceptable.
Details

jnurthen added a commit that referenced this pull request Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.