-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "getVSS" to "discover" #210
Comments
Hi @acrofts84 san I think abstraction of 'getVSS' is good idea. By the way, although I am not very familiar with IoT specs, this word "discover" is appropriate for this use case? If the word "discover" is natural in this use case, I'm OK to change. |
I agree "discover" is better |
Although we like 'discover', Adam and I think Urata-san raises a good point and that using 'discover' could be confusing if we use it to discover metadata and e.g WoT use it to discover services. Would it be ok if we replaced getVSS with getMetadata instead (we also considered getSchema, but the method call returns an object with metadata rather than a schema definition, so getMetadata seems clearest) |
Ok, I then change my mind :) getMetaData is more clear, so I am fine with that. |
I also agree with getMetadata |
Excuse me for late reply. I looked more at OIC Core spec and looks, word 'discover' is used not only for 'Endpoint discovery', So, I thought something like 'discoverResouce' could be another candidate So, in our case, I suppose 'getMetadata' matches well. |
I agree that just 'discover' is too generic and somewhat overloaded. @acrofts84, looking at OIC is a good idea because of the interaction with them and making things consistent even across different applications makes a lot of sense. 'discoverResource' has my vote but I am ok with 'getMetadata' although it's a little too generic for my taste. :) |
So I will close this one since this is now changed in the spec to getMetaData |
Changed getVSS to getMetadata in VIAS like VISS #210
In order to further abstract the data model from the access methods, we should rename the "getVSS" method/action to the "discover" method/action.
The text was updated successfully, but these errors were encountered: