Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "getVSS" to "discover" #210

Closed
acrofts84 opened this issue May 25, 2017 · 8 comments
Closed

Change "getVSS" to "discover" #210

acrofts84 opened this issue May 25, 2017 · 8 comments
Labels

Comments

@acrofts84
Copy link
Contributor

In order to further abstract the data model from the access methods, we should rename the "getVSS" method/action to the "discover" method/action.

  • This is familiar parlance within the IoT and will be more familiar to an implementer.
  • This ensures that the spec can still be logically applied to new data models, including but not limited to the VSS.
@aShinjiroUrata
Copy link
Contributor

Hi @acrofts84 san

I think abstraction of 'getVSS' is good idea.

By the way, although I am not very familiar with IoT specs, this word "discover" is appropriate for this use case?
In w3c wot, "Discovery AP" is to discover IoT "things" which is like discovering devices.
http://w3c.github.io/wot/architecture/wot-architecture.html

If the word "discover" is natural in this use case, I'm OK to change.

@PeterWinzell
Copy link
Contributor

I agree "discover" is better

@drkevg
Copy link
Contributor

drkevg commented May 30, 2017

Although we like 'discover', Adam and I think Urata-san raises a good point and that using 'discover' could be confusing if we use it to discover metadata and e.g WoT use it to discover services. Would it be ok if we replaced getVSS with getMetadata instead (we also considered getSchema, but the method call returns an object with metadata rather than a schema definition, so getMetadata seems clearest)

@peterMelco
Copy link
Contributor

Ok, I then change my mind :) getMetaData is more clear, so I am fine with that.

@acrofts84
Copy link
Contributor Author

I also agree with getMetadata

@aShinjiroUrata
Copy link
Contributor

Excuse me for late reply.
I'm OK with the word 'getMetadata'.

I looked more at OIC Core spec and looks, word 'discover' is used not only for 'Endpoint discovery',
used for 'Resouce discovery' as well.
https://openconnectivity.org/developer/specifications

So, I thought something like 'discoverResouce' could be another candidate
but it is not something like commonly used word.

So, in our case, I suppose 'getMetadata' matches well.

@rstreif
Copy link
Contributor

rstreif commented Jun 2, 2017

I agree that just 'discover' is too generic and somewhat overloaded. @acrofts84, looking at OIC is a good idea because of the interaction with them and making things consistent even across different applications makes a lot of sense. 'discoverResource' has my vote but I am ok with 'getMetadata' although it's a little too generic for my taste. :)

@peterMelco
Copy link
Contributor

So I will close this one since this is now changed in the spec to getMetaData

aShinjiroUrata added a commit that referenced this issue Sep 19, 2017
Changed getVSS to getMetadata in VIAS like VISS #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants