Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen2 feature: Filtering #319

Closed
UlfBj opened this issue Nov 21, 2019 · 4 comments
Closed

Gen2 feature: Filtering #319

UlfBj opened this issue Nov 21, 2019 · 4 comments
Labels
VISS v2 Generation Two of the spec

Comments

@UlfBj
Copy link
Contributor

UlfBj commented Nov 21, 2019

This chapter in the Gen2 CORE document needs to be updated.

@UlfBj
Copy link
Contributor Author

UlfBj commented Nov 21, 2019

I will push a PR with an update proposal.

@UlfBj UlfBj added the VISS v2 Generation Two of the spec label Nov 21, 2019
@gunnarx
Copy link

gunnarx commented Dec 5, 2019

For reference, the mentioned PR is #320.

(I want to propose that we try to handle either tickets or PRs but not both for the same issue (I mean if the ticket does not add anything, like here).

In GitHub they are somewhat equal -- they use the same number scheme.

Having everything visible in the same place helps but rather than having a list I would then propose to enable the project management and use the Kanban board it provides. It handles tickets and PRs equally, so you don't need to have duplicates of the same thing. This matches also the previous request to work with a typical agile process, where it can be highlighted which tickets/PRs we prioritize at this moment @peterMelco)

@UlfBj
Copy link
Contributor Author

UlfBj commented Dec 5, 2019

I agree that having things that are related on more than one place is not ideal.

However, the working model that we decided on in WG, to my understanding, was the following:

  1. Create an issue on something to be worked on in the spec.
  2. Someone adds a comment to take on the task.
  3. The result of the task results in a PR.
  4. A discussion might start on the PR thread to sort out major objections.
  5. The PR is merged and closed.
  6. Remaining minor objections continue to be discussed on the Issue thread, and resolved as new PRs.

So when the PR is open the discussion should be held there, before and after the discussion is held on the Issue thread.
I think it works, but maybe it can be improved.

@UlfBj
Copy link
Contributor Author

UlfBj commented Jun 1, 2020

This was implemented in PR#320.

@UlfBj UlfBj closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VISS v2 Generation Two of the spec
Projects
None yet
Development

No branches or pull requests

2 participants