Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data types #302

Merged
merged 8 commits into from
Apr 16, 2019
Merged

Data types #302

merged 8 commits into from
Apr 16, 2019

Conversation

PatrickCQ
Copy link
Contributor

The intention of this PR is to reduce the amount of data-types to be implemented in a transport protocol and to be handled by all implementations manipulating data.

Through the reduction of several data-types expressing numbers the implementation in an transport protocol becomes easier.
As all memory used by data-types has to be defined the so called restriction (seen from the stand point of using a data-value) define the necessary memory to be allocated.
The set of pre-defined restriction are introduced to help existing implementations and descriptions to be used within Gen2.
Just brought in a new wording to be in line with the other descriptions.
Add restriction idea to strings to allow to allocate memory.
Additionally introduced regex to describe in more detail what a specifc string should look like.
Update description to reflect use-cases.
Add idea of restrictions to allow for memory allocation.
@PatrickCQ PatrickCQ added the VISS v2 Generation Two of the spec label Apr 3, 2019
Copy link
Contributor

@PeterWinzell PeterWinzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolution MUST . ...
must what ? some part missing here.

of not nearer specified data ... is that not what a byte array is ?

also known as a blob is an byte array : I think it should be a byte array

@ghost
Copy link

ghost commented Apr 4, 2019

  1. Resolution or Precision? In case of floating point numbers I would favor the later. For floating point number the encoding should be specified.
  2. Note sure about the naming of "ByteBuffer", ByteArray of Sequence would be more appropriate I think.

Should we express that the intented target of min/max/resolution is the function that will make use of the data, not the serializer (i.e. it takes 3 bytes to express 255 in json but the data itself is really only one byte)

introducing the description of precision.
same way to describe all maximum, minimum and precision values.
as described in the feedback
<td>2^64-1</td>
<td></td></tr>
<tr><th><dfn>Int64</dfn></th>
<td>unsigned 32-bit integer</td>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsigned 32 bit?

@PatrickCQ PatrickCQ merged commit 581a7a0 into w3c:gh-pages Apr 16, 2019
@PatrickCQ PatrickCQ deleted the data-types branch April 16, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VISS v2 Generation Two of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants