-
Notifications
You must be signed in to change notification settings - Fork 12
Add Accessibility considerations section #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds comprehensive accessibility guidance to the badging specification by replacing a placeholder issue with detailed accessibility considerations. The changes focus on ensuring badge implementations are accessible through screen readers, visual accessibility features, and platform integration.
- Added detailed accessibility requirements and recommendations for badge implementations
- Expanded guidance on screen reader compatibility, visual accessibility, and platform integration
- Added semantic improvement with an ID attribute for better document navigation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems pretty reasonable to me - I'm pretty far from an accessibility expert though, so it'd be good to get some other eyes on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @marcoscaceres
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
<h2> | ||
Accessibility considerations | ||
</h2> | ||
<p> | ||
Application badges convey status that can require the user's attention. | ||
Because badges are often presented outside the web content area (for | ||
example, on an app icon in the dock), user agents need to ensure that the | ||
information remains accessible and controllable through platform | ||
accessibility features and user preferences. | ||
</p> | ||
<h3> | ||
Screen reader compatibility | ||
</h3> | ||
<p> | ||
User agents SHOULD expose the current [=badge/value=] (including | ||
[=badge/"flag"=] vs. [=badge/number=]) through platform accessibility | ||
APIs so that assistive technologies can present it on demand (for | ||
example, when the user focuses the application icon). | ||
</p> | ||
<p> | ||
User agents <em>SHOULD NOT</em> automatically announce badge changes; | ||
instead, they SHOULD follow platform conventions that avoid unsolicited | ||
interruptions. | ||
</p> | ||
<h3 class="informative"> | ||
Visual accessibility | ||
</h3> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section opening tag on line 389 is removed but the section is not properly closed in the new structure. The accessibility considerations content should be wrapped in a proper section element to maintain semantic HTML structure.
Copilot uses AI. Check for mistakes.
Closes #24
This pull request updates the
index.html
file to improve accessibility guidance and semantic structure for application badges. The most significant changes are the addition of detailed accessibility considerations, including recommendations for screen reader compatibility, visual accessibility, and platform integration, as well as a minor semantic improvement to section headings.Accessibility improvements:
Semantic improvements:
id
attribute to the "Displaying a badge" heading for easier navigation and referencing.This change (choose at least one, delete ones that don't apply):
Implementation commitment (delete if not making normative changes):
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
Preview | Diff