Skip to content

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 3, 2025

Closes #24

This pull request updates the index.html file to improve accessibility guidance and semantic structure for application badges. The most significant changes are the addition of detailed accessibility considerations, including recommendations for screen reader compatibility, visual accessibility, and platform integration, as well as a minor semantic improvement to section headings.

Accessibility improvements:

  • Added a comprehensive "Accessibility considerations" section with guidance for user agents on exposing badge status through platform accessibility APIs, following platform conventions for announcements, and integrating with user preferences.
  • Included a "Screen reader compatibility" subsection detailing how badge values should be exposed and when announcements should occur.
  • Added a "Visual accessibility" subsection with recommendations for color contrast, legibility, and honoring user settings like high-contrast mode and reduced motion.
  • Introduced a "Platform integration and user preferences" subsection to ensure badges respect OS-level settings and user preferences.

Semantic improvements:

  • Added an id attribute to the "Displaying a badge" heading for easier navigation and referencing.

This change (choose at least one, delete ones that don't apply):

  • Adds new normative requirements

Implementation commitment (delete if not making normative changes):

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:
  • editorial:
  • BREAKING CHANGE:
  • And use none if it's a normative change

Preview | Diff

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds comprehensive accessibility guidance to the badging specification by replacing a placeholder issue with detailed accessibility considerations. The changes focus on ensuring badge implementations are accessible through screen readers, visual accessibility features, and platform integration.

  • Added detailed accessibility requirements and recommendations for badge implementations
  • Expanded guidance on screen reader compatibility, visual accessibility, and platform integration
  • Added semantic improvement with an ID attribute for better document navigation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems pretty reasonable to me - I'm pretty far from an accessibility expert though, so it'd be good to get some other eyes on it

@matatk matatk added the a11y-tracker Group bringing to attention of a11y, or tracked by the a11y Group but not needing response. label Sep 4, 2025
@marcoscaceres marcoscaceres added a11y-needs-resolution Issue the Accessibility Group has raised and looks for a response on. and removed a11y-needs-resolution Issue the Accessibility Group has raised and looks for a response on. labels Sep 24, 2025
Copy link
Collaborator

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @marcoscaceres

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +389 to +416
<h2>
Accessibility considerations
</h2>
<p>
Application badges convey status that can require the user's attention.
Because badges are often presented outside the web content area (for
example, on an app icon in the dock), user agents need to ensure that the
information remains accessible and controllable through platform
accessibility features and user preferences.
</p>
<h3>
Screen reader compatibility
</h3>
<p>
User agents SHOULD expose the current [=badge/value=] (including
[=badge/"flag"=] vs. [=badge/number=]) through platform accessibility
APIs so that assistive technologies can present it on demand (for
example, when the user focuses the application icon).
</p>
<p>
User agents <em>SHOULD NOT</em> automatically announce badge changes;
instead, they SHOULD follow platform conventions that avoid unsolicited
interruptions.
</p>
<h3 class="informative">
Visual accessibility
</h3>
<p>
Copy link
Preview

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section opening tag on line 389 is removed but the section is not properly closed in the new structure. The accessibility considerations content should be wrapped in a proper section element to maintain semantic HTML structure.

Copilot uses AI. Check for mistakes.

@marcoscaceres marcoscaceres merged commit f04f961 into main Sep 30, 2025
2 checks passed
@marcoscaceres marcoscaceres deleted the a11y branch September 30, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-tracker Group bringing to attention of a11y, or tracked by the a11y Group but not needing response.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accessibility section
3 participants