Skip to content

Fix penalty algorithm #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 31, 2023
Merged

Fix penalty algorithm #230

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d22499b
Fix penalty algorithm
arskama Aug 25, 2023
ced5fb2
Fix comment from Rakuco.
arskama Aug 28, 2023
6caac9f
Fix corner-cases when new state changes are coming during penalty.
arskama Aug 28, 2023
58e8f02
Update index.html
arskama Aug 28, 2023
bfdb92e
Update index.html
arskama Aug 28, 2023
9d84e38
Fix wording and unobserve, disconnect steps.
arskama Aug 30, 2023
3dd5ec8
small fix on map remove
arskama Aug 30, 2023
50175e7
fix Put Continue as a separate step.
arskama Aug 30, 2023
4f93f02
fix rakuco s comment on unobserve/disconnect
arskama Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,9 @@ <h3>The <dfn>unobserve()</dfn> method</h3>
<li>
[=map/Remove=] |this|.{{PressureObserver/[[LastRecordMap]]}}[|source|].
</li>
<li>
[=map/Remove=] |this|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[|source|].
</li>
<li>
[=list/For each=] (|promiseSource|, |pendingPromise|) of [=this=].{{PressureObserver/[[PendingObservePromises]]}},
if |source| is equal to |promiseSource|, [=reject=] |pendingPromise| with an {{AbortError}}.
Expand Down Expand Up @@ -646,6 +649,9 @@ <h3>The <dfn>disconnect()</dfn> method</h3>
<li>
[=map/Clear=] |this|.{{PressureObserver/[[LastRecordMap]]}}.
</li>
<li>
[=map/Clear=] |this|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}.
</li>
<li>
[=list/For each=] (|promiseSource|, |pendingPromise|) of [=this=].{{PressureObserver/[[PendingObservePromises]]}},
[=reject=] |pendingPromise| with an {{AbortError}}.
Expand Down Expand Up @@ -1051,24 +1057,41 @@ <h3>Data delivery</h3>
and {{PressureRecord/[[Time]]}} set to |timestamp|.
</li>
<li>
If |observer|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[source] exists,
set observer.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[source] to |record|
and [=iteration/continue=].
If |observer|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[source] [=map/exists]:
<ol>
<li>
Set |observer|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[|source|] to |record|.
</li>
<li>
[=iteration/Continue=].
</li>
</ol>
</li>
<li>
If running [=passes rate obfuscation test=] with |observer| and |source| returns false:
<ol>
<li>
Set |observer|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[|source|] to |record|.
</li>
<li>
Set |observer|.{{PressureObserver/[[ChangesCountMap]]}}[|source|] to 0.
</li>
<li>
Create timer of |observer|.{{PressureObserver/[[PenaltyDuration]]}} duration with the following callback:
<ol>
<li>
Let |record| be the result of taking |observer|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[|source|].
</li>
<li>
Run [=queue a record=] with |observer|, |source|, |record|.
If |observer|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[source] [=map/exists]:
<ol>
<li>
Let |record| be |observer|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[|source|].
</li>
<li>
[=map/Remove=] |observer|.{{PressureObserver/[[AfterPenaltyRecordMap]]}}[|source|].
</li>
<li>
Run [=queue a record=] with |observer|, |source|, |record|.
</li>
</ol>
</li>
</ol>
</li>
Expand Down