Skip to content

Fix #281: Get rid of the global current pressure state #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix #281: Get rid of the global current pressure state #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,9 +407,6 @@ <h3>
<p>
Each [=global object=] has:
<ul>
<li>
a <dfn>current pressure state</dfn> (a string), initialized to the empty string.
</li>
<li>
a <dfn>pressure observer task queued</dfn> (a boolean), which is initially false.
</li>
Expand Down Expand Up @@ -474,7 +471,7 @@ <h3>
</li>
<li>
a <dfn>[[\ChangesCountMap]]</dfn> [=ordered map=], [=map/keyed=] on a {{PressureSource}},
representing the [=source type=] that triggered transition to the [=current pressure state=].
representing the [=source type=] that triggered transition to the current [=pressure state=].
The [=ordered map=]'s [=map/value=] is an integer representing the number of state changes in the
current observation window timeframe.
</li>
Expand Down Expand Up @@ -523,7 +520,7 @@ <h3>

<section> <h2>Contributing Factors</h2>
<p>
<dfn>Contributing factors</dfn> represent the underlying hardware metrics contributing to the [=current pressure state=]
<dfn>Contributing factors</dfn> represent the underlying hardware metrics contributing to the current [=pressure state=]
and can be [=implementation-defined=].
</p>
<p>
Expand All @@ -536,9 +533,9 @@ <h3>
<ol>
<li>
If [=implementation-defined=] low-level hardware metrics that contribute to the
[=current pressure state=] drop below or exceed an, per metric,
current [=pressure state=] drop below or exceed an, per metric,
[=implementation-defined=] threshold
for the [=current pressure state=], return true.
for the current [=pressure state=], return true.
</li>
<li>
Return false.
Expand Down Expand Up @@ -948,7 +945,7 @@ <h3>The <dfn>PressureRecord</dfn> interface</h3>
a <dfn>[[\Source]]</dfn> value of type {{PressureSource}}, which represents the current [=source type=].
</li>
<li>
a <dfn>[[\State]]</dfn> value of type {{PressureState}}, which represents the [=current pressure state=].
a <dfn>[[\State]]</dfn> value of type {{PressureState}}, which represents the current [=pressure state=].
</li>
<li>
a <dfn>[[\Time]]</dfn> value of type {{DOMHighResTimeStamp}},
Expand Down Expand Up @@ -1227,8 +1224,7 @@ <h3>Supporting algorithms</h3>
Let |record:PressureRecord| be |observer|.{{PressureObserver/[[LastRecordMap]]}}[|source|].
</li>
<li>
If |record|.{{PressureRecord/[[State]]}} is not equal to |state| and [=change in contributing factors is substantial=]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to the rest? It doesn't seem to reference [=current pressure state=].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. This is done on the global value now instead of per observer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It'd be good to explain this in the commit/PR message, as it's not immediately clear just by looking at the patch.

returns true, return true.
If |record|.{{PressureRecord/[[State]]}} is not equal to |state|, return true.
</li>
<li>
Return false.
Expand Down Expand Up @@ -1408,6 +1404,9 @@ <h3>Data Collection and Delivery</h3>
<li>
Otherwise:
<ol>
<li>
If [=change in contributing factors is substantial=] is false, abort these steps.
</li>
<li>
Set |state| to an [=adjusted pressure state=] calculated from
|source| and |sample|'s [=pressure source sample/data=].
Expand Down
Loading