Skip to content

Conversation

TallTed
Copy link
Member

@TallTed TallTed commented Jun 10, 2024

follows on #1
replaces #13


Preview | Diff

follows on #1
replaces #13
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor nit.

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@msporny
Copy link
Member

msporny commented Jun 17, 2024

Can you try to fix the merge conflicts in this PR, @TallTed?

@TallTed
Copy link
Member Author

TallTed commented Jun 17, 2024

Fixed the conflict. A new question follows...

@iherman
Copy link
Member

iherman commented Jun 19, 2024

The issue was discussed in a meeting on 2024-06-19

  • no resolutions were taken
View the transcript

3.2. fix grammar, add links (pr controller-document#30)

See github pull request controller-document#30.

Brent Zundel: Looking at 30. Call for summary review.
… Editorial fixes, links added. Thanks to TallTed for raising. Nothing controversial.

Brent Zundel: https://github.com/w3c/controller-document/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-asc.

Brent Zundel: On to looking at issues.

KevinDean: Start with 5.

@iherman
Copy link
Member

iherman commented Jun 26, 2024

The issue was discussed in a meeting on 2024-06-26

  • no resolutions were taken
View the transcript

3.2. fix grammar, add links (pr controller-document#30)

See github pull request controller-document#30.

Brent Zundel: has a lot of approvals so will be merged after this meeting.

Ted Thibodeau Jr.: there is still one open question did URI or https URL.

Manu Sporny: https.

@msporny
Copy link
Member

msporny commented Jun 30, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 1de613e into main Jun 30, 2024
@msporny msporny deleted the TallTed-pr30 branch June 30, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants