Skip to content

[css-typed-om] Remove skew/rotate double constructors, and change angle member type #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[css-typed-om] Remove skew/rotate double constructors, and change angle member type #279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09f2b8b
Add constructor for CSSSkew with CSSAngleValues
rjwright Jul 28, 2016
ccb89a5
Remove double constructors for CSSRotation and CSSSkew, and change an…
rjwright Aug 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions css-typed-om/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,15 +459,13 @@ interface CSSTranslation : CSSTransformComponent {
readonly attribute CSSLengthValue z;
};

[Constructor(double degrees),
Constructor(CSSAngleValue angle),
Constructor(double x, double y, double z, double degrees),
[Constructor(CSSAngleValue angle),
Constructor(double x, double y, double z, CSSAngleValue angle)]
interface CSSRotation : CSSTransformComponent {
readonly attribute double x;
readonly attribute double y;
readonly attribute double z;
readonly attribute double angle;
readonly attribute CSSAngleValue angle;
};

[Constructor(double x, double y),
Expand All @@ -478,10 +476,10 @@ interface CSSScale : CSSTransformComponent {
readonly attribute double z;
};

[Constructor(double ax, double ay)]
[Constructor(CSSAngleValue ax, CSSAngleValue ay)]
interface CSSSkew : CSSTransformComponent {
readonly attribute double ax;
readonly attribute double ay;
readonly attribute CSSAngleValue ax;
readonly attribute CSSAngleValue ay;
};

[Constructor(CSSLengthValue length)]
Expand Down Expand Up @@ -517,17 +515,6 @@ and y & z values of 0 could be:

</div>

When a {{CSSRotation}} is constructed with a double (as opposed to a
{{CSSAngleValue}}), the angle is taken to be in degrees.

<div class=note>
The following two CSSRotations are equivalent:
<pre class='lang-javascript'>
CSSRotation(angle);
CSSRotation(CSSAngleValue(angle, "deg"));
</pre>
</div>

When a {{CSSTransformValue}} is read from a {{StylePropertyMap}}, each
{{CSSTransformComponent}} will maintain the relevant transform function in
its <code>cssText</code> attribute. However, newly constructed {{CSSTransformValue}}s
Expand Down