Skip to content

Fix for issue 276 #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix for issue 276 #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions css-typed-om/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,13 @@ the [=property model=]. This list of properties is sorted in the following manne
* custom properties are sorted by increasing code point order.
* custom properties are sorted after normal properties.

The getProperties() method returns the following for custom properties:
* For Inline StylePropertyMap it should return the custom properties that are set on the inline style of the current Node.
* For Declared StylePropertyMap, should return the custom properties defined in the current style rule.
* For Computed StylePropertyMap it should return all custom properties defined on the current Node and its ancestors. Please note that only custom properties that have an initial value show up in the Computed StylePropertyMap.

The method should also warn authors about performance issues if they type untyped custom properties.

Issue(145): should refactor out value type-checking, as it'll be needed by the rest of the setters too

Issue(148): add detailed descriptions of the rest of the methods on {{StylePropertyMap}}
Expand Down