Add wording for CSSNumericValue.type() #546
Conversation
|
@tabatkins Can you PTAL at the proposed IDL when you have time? Thanks! |
|
Note that whether the base types should be required or optional depends on whether we need to differentiate between the types I don't think this has any observable impact on arithmetic, so only Maybe @shans can weigh in on this as well since I asked him a similar question a while back. |
|
Nah, I can't find why I would have wanted to distinguish a zero exponent from a null exponent. All the algorithms are careful to only talk about non-zero exponents. And I'd probably want |
|
Thanks, I think @shans mentioned that animations distinguish between zero/null or something, but I don't know how useful that is for Typed OM. Anyway, it looks like exponents should be optional either way. We can always distinguish zero/null later with no impact on the API. |
|
Yeah, we want to preserve zero values in a calc(), so the "shape" remains stable when animating across 0, but that reasoning doesn't apply to zero exponents in the type; those don't change in animations. ^_^ |
|
|
||
| <div algorithm="CSSNumericValue.type()"> | ||
| The <dfn method for=CSSNumericValue>type()</dfn> method | ||
| returns a representation of the [=type=] of |this|. |
There was a problem hiding this comment.
Might be better ways of saying this.
css-typed-om/Overview.bs
Outdated
|
|
||
| When called, it must perform the following steps: | ||
|
|
||
| 1. Let |result| be a new {{CSSNumericType}} with all attributes set to `null`. |
There was a problem hiding this comment.
Can I omit the "with all attributes set to null" since it's probably the default behaviour?
css-typed-om/Overview.bs
Outdated
|
|
||
| 2. For each |baseType| → |power| in the [=type=] of |this|, | ||
| 1. If |power| is not 0, | ||
| set |result|'s |baseType| attribute to |power|. |
There was a problem hiding this comment.
Not sure if attribute is the correct term. Maybe slot?
There was a problem hiding this comment.
The term for dictionaries is "member". Alternately, since per WebIDL you're allowed to treat dictionaries as ordered maps, you can just say "set |result|[|baseType|] to |power|".
| set |result|'s |baseType| attribute to |power|. | ||
|
|
||
| 3. If the [=percent hint=] of |this| is not null, | ||
| 1. Set {{CSSNumericType/percentHint}} to the [=percent hint=] of |this|. |
There was a problem hiding this comment.
This is a bit handwavy as it doesn't quite type check - CSSNumericType.percentHint is an enum whereas the percent hint of this is a string (I think).
There was a problem hiding this comment.
I think that's fine - enums turn into strings when they go to ECMAScript anyway.
|
Cool, made the requested changes. PTAL |
2 participants
issue #482
Hi @tabatkins, PTAL. I'm not sure if I'm doing this right, so I only wrote up the interface for now. I'll do the actual text once we've agreed on the interface.