Skip to content

Remove StylePropertyMap.update() #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Remove StylePropertyMap.update() #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions css-typed-om/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,13 +241,10 @@ interface StylePropertyMapReadOnly {
stringifier;
};

callback UpdateFunction = CSSStyleValue (CSSStyleValue oldValue);

[Exposed=Window]
interface StylePropertyMap : StylePropertyMapReadOnly {
void set(DOMString property, (CSSStyleValue or DOMString)... values);
void append(DOMString property, (CSSStyleValue or DOMString)... values);
void update(DOMString property, UpdateFunction updateFunction);
void delete(DOMString property);
void clear();
};
Expand Down Expand Up @@ -439,22 +436,6 @@ probably in an appendix.
8. [=list/Append=] the entries of |temp values| to |props|[|property|].
</div>

<div algorithm>
The <dfn method for=StylePropertyMap>update(|property|, |updateFn|)</dfn> method,
when called on a {{StylePropertyMap}} |this|,
must perform the following steps:

1. Let |old value| be the result of calling |this|.get(|property|)
(using the original value of {{StylePropertyMap/get()}}).

2. Let |new value| be the result of [=invoking=] |updateFn| with |old value|.

3. Call |this|.set(|property|, |new value|)
(using the original value of {{StylePropertyMap/set()}}).
</div>

Issue(645): Do we need an updateAll() method that gets and sets a list?

<div algorithm>
The <dfn method for=StylePropertyMap>delete(|property|)</dfn> method,
when called on a {{StylePropertyMap}} |this|,
Expand Down