Skip to content

[css-animationworklet] update ScrollTimeline usage in examples #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2018
Merged

[css-animationworklet] update ScrollTimeline usage in examples #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce5780b
[css-animationworklet] update ScrollTimeline usage in examples to mat…
majido Aug 27, 2018
2483a00
Merge branch 'master' into fix-scrolltimeline-examples
bfgeek Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions css-animationworklet/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,11 @@ animates fully to close or open position depending on its current position.

<script>
await CSS.animationWorklet.addModule('hidey-bar-animator.js');
const scrollTimeline = new ScrollTimeline($scrollingContainer, {timeRange: 1000});
const scrollTimeline = new ScrollTimeline({
scrollSource: $scrollingContainer,
orientation: 'block',
timeRange: 1000
});
const documentTimeline = document.timeline;

// Note we pass in two timelines in the options bag which allows the animation to read their
Expand Down Expand Up @@ -829,7 +833,12 @@ const animation = new WorkletAnimation(
new KeyframeEffect($header, /* loses transparency as we scroll up */
[{opacity: 0}, {opacity: 0.8}],
{duration: 1000, iterations: 1})],
new ScrollTimeline($scrollingContainer, {timeRange: 1000, startScrollOffset: 0, endScrollOffset: $header.clientHeight}));
new ScrollTimeline({
scrollSource: $scrollingContainer,
orientation: 'block',
timeRange: 1000,
startScrollOffset: 0,
endScrollOffset: $header.clientHeight}));
animation.play();

// Since this animation is using a group effect, the same animation instance
Expand Down Expand Up @@ -880,7 +889,11 @@ A simple parallax background example.

<script>
await CSS.animationWorklet.addModule('parallax-animator.js');
const scrollTimeline = new ScrollTimeline($scrollingContainer, {timeRange: 1000});
const scrollTimeline = new ScrollTimeline({
scrollSource: $scrollingContainer,
orientation: 'block',
timeRange: 1000
});
const scrollRange = $scrollingContainer.scrollHeight - $scrollingContainer.clientHeight;

const slowParallax = new WorkletAnimation(
Expand Down
22 changes: 18 additions & 4 deletions css-animationworklet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,12 @@ it animates fully to close or open position depending on its current position.

<script>
await CSS.animationWorklet.addModule('hidey-bar-animator.js');
const scrollTimeline = new ScrollTimeline($scrollingContainer, {timeRange: 100});

const scrollTimeline = new ScrollTimeline({
scrollSource: $scrollingContainer,
orientation: 'block',
timeRange: 100
});
const documentTimeline = document.timeline;


Expand Down Expand Up @@ -249,8 +254,13 @@ const animation = new WorkletAnimation('twitter-header',
{duration: 1000, iterations: 1}),
new KeyframeEffect($header, /* loses transparency as we scroll up */
[{opacity: 0}, {opacity: 0.8}],
{duration: 1000, iterations: 1})] ,
new ScrollTimeline($scrollingContainer, {timeRange: 1000, startScrollOffset: 0, endScrollOffset: $header.clientHeight}),
{duration: 1000, iterations: 1})],
new ScrollTimeline({
scrollSource: $scrollingContainer,
timeRange: 1000,
orientation: 'block',
startScrollOffset: 0,
endScrollOffset: $header.clientHeight}),
);
animation.play();
</script>
Expand Down Expand Up @@ -296,7 +306,11 @@ registerAnimator('twitter-header', class {

<script>
await CSS.animationWorklet.addModule('parallax-animator.js');
const scrollTimeline = new ScrollTimeline($scrollingContainer, {timeRange: 1000});
const scrollTimeline = new ScrollTimeline({
scrollSource: $scrollingContainer,
orientation: 'block',
timeRange: 1000
});
const scrollRange = $scrollingContainer.scrollHeight - $scrollingContainer.clientHeight;

const slowParallax = new WorkletAnimation(
Expand Down