-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-ui] appearance: menulist-button is different from auto #3574
Merged
zcorpan
merged 1 commit into
w3c:master
from
zcorpan:zcorpan/appearance-menulist-button
May 21, 2019
Merged
[css-ui] appearance: menulist-button is different from auto #3574
zcorpan
merged 1 commit into
w3c:master
from
zcorpan:zcorpan/appearance-menulist-button
May 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
May 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review of CSS spec material, but LGTM.
Gecko bug The test that fails in Firefox in web-platform-tests/wpt#14996 is |
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 21, 2019
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 21, 2019
Follows w3c/csswg-drafts#3545 w3c/csswg-drafts#3546 w3c/csswg-drafts#3574 Co-Authored-By: Philip Jägenstedt <philip@foolip.org>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 19, 2019
… and 'auto', a=testonly Automatic update from web-platform-tests [css-ui] Test appearance <compat> values and 'auto' Follows w3c/csswg-drafts#3545 w3c/csswg-drafts#3546 w3c/csswg-drafts#3574 Co-Authored-By: Philip Jägenstedt <philip@foolip.org> -- wp5At-commits: 31e7edc073c29fec0e708a2e883c774b55452421 wpt-pr: 14996
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 19, 2019
… and 'auto', a=testonly Automatic update from web-platform-tests [css-ui] Test appearance <compat> values and 'auto' Follows w3c/csswg-drafts#3545 w3c/csswg-drafts#3546 w3c/csswg-drafts#3574 Co-Authored-By: Philip Jägenstedt <philip@foolip.org> -- wp5At-commits: 31e7edc073c29fec0e708a2e883c774b55452421 wpt-pr: 14996
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
Follows w3c/csswg-drafts#3545 w3c/csswg-drafts#3546 w3c/csswg-drafts#3574 Co-Authored-By: Philip Jägenstedt <philip@foolip.org>
This was referenced Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3551
Tests: web-platform-tests/wpt#14996
cc @MatsPalmgren @tkent-google