Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ui-4] Added image-set() function to 'cursor' property #6153

Closed
wants to merge 3 commits into from

Conversation

SebastianZ
Copy link
Contributor

This change adds the image-set() function to the cursor property.

It got implemented in Gecko lately and WebKit has support for a prefixed version of it.

Together with the addition of the function I've also adjusted the syntax a little bit for better readability and fixed some links to CSS Backgrounds 3 because otherwise Bikeshed marks them as fatal errors and doesn't compile the spec.

Closes #5831

Sebastian

@tabatkins
Copy link
Member

This should just be swapping the <<url>> for <<image>>, right? There's no reason to limit it to solely image-set(), particularly since you can put any <<image>> you want inside of image-set().

@tabatkins
Copy link
Member

(See #5834 for the earlier discussion on this.)

@SebastianZ
Copy link
Contributor Author

Based on Mozilla's implementation issue I mentioned in the other PR and my tests in Firefox Nightly 88, image-set() is actually restricted to URLs for the cursor property, while it also takes gradients in other properties.

So I guess a different version of image-set() with restricted syntax needs to be defined for this case.

But let's see what Emilio has to say in the other PR.

Sebastian

@SebastianZ SebastianZ changed the title Added image-set() function to 'cursor' property [css-ui-4] Added image-set() function to 'cursor' property Mar 23, 2022
@SebastianZ SebastianZ added the css-ui-4 Current Work label Mar 23, 2022
@frivoal
Copy link
Collaborator

frivoal commented Apr 7, 2022

This has been made redundant by 78fb03b

@frivoal frivoal closed this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-ui-4 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-ui] Should the cursor property support image-set()?
3 participants