[css-grid-3] [Masonry] Remove Align-Tracks and Justify-Tracks #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 2, 2024
…s' properties. r=emilio These properties were added as part of the experimental Masonry support added in bug 1607954. Since then the CSS WG resolved to remove these properties in: w3c/csswg-drafts#9529 This patch is a fairly brain dead removal of the properties, simply changing the consumer code to take the code paths that would have been taken previously if the properties were not set. That leaves some obvious dead code, which has been removed, but no attempt has been made to redesign the Masonry code to "make sense" without these properties. That would require a more prolonged effort to understand Masonry, how the spec has changed in the last four years, and how we should best change our code. For now, this removal is simply focused on reducing the amount of memory used by nsStyleDisplay to unblock the landing of bug 1899949. Differential Revision: https://phabricator.services.mozilla.com/D212358
github-actions bot
pushed a commit
to servo/stylo
that referenced
this pull request
Jun 2, 2024
…s' properties. r=emilio These properties were added as part of the experimental Masonry support added in bug 1607954. Since then the CSS WG resolved to remove these properties in: w3c/csswg-drafts#9529 This patch is a fairly brain dead removal of the properties, simply changing the consumer code to take the code paths that would have been taken previously if the properties were not set. That leaves some obvious dead code, which has been removed, but no attempt has been made to redesign the Masonry code to "make sense" without these properties. That would require a more prolonged effort to understand Masonry, how the spec has changed in the last four years, and how we should best change our code. For now, this removal is simply focused on reducing the amount of memory used by nsStyleDisplay to unblock the landing of bug 1899949. Differential Revision: https://phabricator.services.mozilla.com/D212358
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jun 5, 2024
…s' properties. r=emilio These properties were added as part of the experimental Masonry support added in bug 1607954. Since then the CSS WG resolved to remove these properties in: w3c/csswg-drafts#9529 This patch is a fairly brain dead removal of the properties, simply changing the consumer code to take the code paths that would have been taken previously if the properties were not set. That leaves some obvious dead code, which has been removed, but no attempt has been made to redesign the Masonry code to "make sense" without these properties. That would require a more prolonged effort to understand Masonry, how the spec has changed in the last four years, and how we should best change our code. For now, this removal is simply focused on reducing the amount of memory used by nsStyleDisplay to unblock the landing of bug 1899949. Differential Revision: https://phabricator.services.mozilla.com/D212358
This was referenced Jul 3, 2024
nicoburns
pushed a commit
to nicoburns/stylo
that referenced
this pull request
Jul 10, 2024
…s' properties. r=emilio These properties were added as part of the experimental Masonry support added in bug 1607954. Since then the CSS WG resolved to remove these properties in: w3c/csswg-drafts#9529 This patch is a fairly brain dead removal of the properties, simply changing the consumer code to take the code paths that would have been taken previously if the properties were not set. That leaves some obvious dead code, which has been removed, but no attempt has been made to redesign the Masonry code to "make sense" without these properties. That would require a more prolonged effort to understand Masonry, how the spec has changed in the last four years, and how we should best change our code. For now, this removal is simply focused on reducing the amount of memory used by nsStyleDisplay to unblock the landing of bug 1899949. Differential Revision: https://phabricator.services.mozilla.com/D212358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #8208 and #8207