Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Revert "Remove trailing whitespace" for white-space tests #979

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

hakatashi
Copy link

I believe the recent "Remove trailing whitespace" commit broke tests for that white space.

Review on Reviewable

@syncbot
Copy link
Collaborator

syncbot commented Dec 10, 2015

Automatic validation checks of commit 7b73103 passed.

@hakatashi hakatashi changed the title Revert 55a4412 for white-space tests Revert "Remove trailing whitespace" for white-space tests Dec 10, 2015
@Ms2ger
Copy link

Ms2ger commented Dec 10, 2015

Thanks for catching this, and apologies for the mixup.

Ms2ger added a commit that referenced this pull request Dec 10, 2015
Revert "Remove trailing whitespace" for white-space tests
@Ms2ger Ms2ger merged commit 7175835 into w3c:master Dec 10, 2015
@hakatashi hakatashi deleted the revert-white-spaces-test branch December 10, 2015 14:07
@gsnedders
Copy link
Member

IMO it'd be better to use character references instead of (invisible, trailing) whitespace characters in these tests. It'd make them much easier to read, I think. @hakatashi @r12a?

@r12a
Copy link

r12a commented Dec 14, 2015

@gsnedders that seemed like a sensible suggestion, so i took some time to update the files and created a PR #982

@Ms2ger please don't change tests that i submit without checking with me first, since i use the tests in other places, beside this repository, and need to keep the files the same in all locations.

@r12a
Copy link

r12a commented Dec 14, 2015

btw, @hakatashi many thanks for spotting this!

@hakatashi
Copy link
Author

Not at all 😃 I'm here because I'm currently implementing a module to simulate this draft spec and just quoting the test.

@Ms2ger
Copy link

Ms2ger commented Dec 14, 2015

@r12a if you don't want tests to be changed, please remove them from this repository.

@r12a
Copy link

r12a commented Dec 14, 2015

@Ms2ger i didn't say that i didn't want tests to change. I asked that you notify me beforehand so that (1) we can avoid wasting time putting things back when necessary, and (2) so that i can update the tests in other places where i use them where a change is needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants