Skip to content

Issue 230: Update description of sh:pattern behavior with IRI nodes #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Issue 230: Update description of sh:pattern behavior with IRI nodes #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data-shapes-test-suite/tests/core/node/pattern-001.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ ex:TestShape
rdf:type sh:ValidationResult ;
sh:focusNode ex:Test ;
sh:resultSeverity sh:Violation ;
sh:sourceConstraintComponent sh:PatternConstraintComponent ;
sh:sourceConstraintComponent sh:NodeKindConstraintComponent ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original was right, this is wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection with rolling this back, but I'd like the reasoning to be unambiguous from updates to the SHACL-Core document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should be sh:PatternConstraintComponent (which jena-shacl passes).

Even if it were a blank node - so some kind of argument error - it is sh:sourceConstraintComponent which is the constraint failing, not some kind of an error class.

sh:sourceShape ex:TestShape ;
sh:value ex:Test ;
] ;
Expand Down