Skip to content

Conversation

jeswr
Copy link
Member

@jeswr jeswr commented Jul 10, 2025

Editorial change to add SHACL-C snippets to the core spec document

Closes #419

@jeswr jeswr requested a review from bergos July 10, 2025 13:03
Copy link
Contributor

@bergos bergos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the specification via JavaScript code generates several changes that aren't related to the shaclc snippets. I think these changes should be in a separate commit, separate from the shaclc changes. I don't see any problem with the changes, but others should also review them.

The code and the generated snippets look good.

@jeswr jeswr force-pushed the feat/shaclc-snippets branch from e046a34 to d12c2e3 Compare July 14, 2025 11:35
@jeswr
Copy link
Member Author

jeswr commented Jul 14, 2025

Updating the specification via JavaScript code generates several changes that aren't related to the shaclc snippets. I think these changes should be in a separate commit

These are now done in cf8a8ea including manual adding of <thead> as pointed out by @afs in #421 (comment)

@jeswr jeswr requested review from afs and bergos July 14, 2025 11:38
@jeswr
Copy link
Member Author

jeswr commented Jul 15, 2025

@bergos could you please update your review when you get the chance. @TallTed you may wish to review cf8a8ea, noting that these are largely automated changes to the HTML.

@TallTed
Copy link
Member

TallTed commented Jul 15, 2025

FWIW, everything I see in cf8a8ea looks good.

@jeswr jeswr merged commit b976efa into gh-pages Jul 17, 2025
1 check passed
@jeswr jeswr deleted the feat/shaclc-snippets branch July 17, 2025 10:32
@YoucTagh
Copy link
Contributor

I am adding my review late, but there are 28 Shapes graph boxes with Turtle and JSON-LD only, with no SHACL-C. Is this intentional?

@jeswr
Copy link
Member Author

jeswr commented Aug 4, 2025

I am adding my review late, but there are 28 Shapes graph boxes with Turtle and JSON-LD only, with no SHACL-C. Is this intentional?

Those graph boxes for which there is no SHACL-C are ones for which SHACL-C is not currently expressive enough to describe. The SHACL-C was autogenerated, and autogeneration was skipped if the serializer detected features it could not handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include SHACL-C with TTL and JSON-LD serialisations of shapes in core spec document
5 participants