-
Notifications
You must be signed in to change notification settings - Fork 38
Issue 419: Add shaclc snippets #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the specification via JavaScript code generates several changes that aren't related to the shaclc snippets. I think these changes should be in a separate commit, separate from the shaclc changes. I don't see any problem with the changes, but others should also review them.
The code and the generated snippets look good.
e046a34
to
d12c2e3
Compare
These are now done in cf8a8ea including manual adding of |
FWIW, everything I see in cf8a8ea looks good. |
I am adding my review late, but there are 28 Shapes graph boxes with Turtle and JSON-LD only, with no SHACL-C. Is this intentional? |
Those graph boxes for which there is no SHACL-C are ones for which SHACL-C is not currently expressive enough to describe. The SHACL-C was autogenerated, and autogeneration was skipped if the serializer detected features it could not handle. |
Editorial change to add SHACL-C snippets to the core spec document
Closes #419