Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created errata document #1209

Merged
merged 19 commits into from
Jan 27, 2020
Merged

Created errata document #1209

merged 19 commits into from
Jan 27, 2020

Conversation

andrea-perego
Copy link
Contributor

@andrea-perego andrea-perego commented Jan 17, 2020 •
edited
Loading

@andrea-perego andrea-perego changed the title Created errata document... Created errata document Jan 17, 2020
@andrea-perego andrea-perego mentioned this pull request Jan 17, 2020
Closed
@andrea-perego andrea-perego mentioned this pull request Jan 18, 2020
Merged
@andrea-perego andrea-perego added this to the DCAT2 ratification milestone Jan 19, 2020
riccardoAlbertoni
riccardoAlbertoni reviewed Jan 21, 2020
View reviewed changes
errata/README.md Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Show resolved Hide resolved
errata/test.html Outdated Show resolved Hide resolved
@riccardoAlbertoni riccardoAlbertoni mentioned this pull request Jan 22, 2020
Closed
@riccardoAlbertoni
Copy link
Contributor

Thank Andrea, I like the page you prepared. I only wonder if we need to keep the file LICENSE in the directory to meet the term of the license.

@andrea-perego
Copy link
Contributor Author

@riccardoAlbertoni said:

Thank Andrea, I like the page you prepared. I only wonder if we need to keep the file LICENSE in the directory to meet the term of the license.

I don't think so. My understanding is that that LICENSE file is related to the content of the original repo (display_errata). Also, I haven't found links from the errata document to the LICENSE file.

@riccardoAlbertoni
Copy link
Contributor

@riccardoAlbertoni said:

Thank Andrea, I like the page you prepared. I only wonder if we need to keep the file LICENSE in the directory to meet the term of the license.

I don't think so. My understanding is that that LICENSE file is related to the content of the original repo (display_errata). Also, I haven't found links from the errata document to the LICENSE file.

Ok, Then I would suggest marking this PR as "ready for review" and asking the editors to review it, So that, we can get it merged by the beginning of next week. What do you think?

@andrea-perego
Copy link
Contributor Author

+1 from me.

@andrea-perego andrea-perego marked this pull request as ready for review January 24, 2020 22:25
@agbeltran agbeltran merged commit c1b370c into gh-pages Jan 27, 2020
@agbeltran agbeltran deleted the andrea-perego-dxwg-errata branch January 27, 2020 22:34
@riccardoAlbertoni
Copy link
Contributor

also related to #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agbeltran agbeltran agbeltran approved these changes

@riccardoAlbertoni riccardoAlbertoni riccardoAlbertoni approved these changes

@davebrowning davebrowning Awaiting requested review from davebrowning

@dr-shorthair dr-shorthair Awaiting requested review from dr-shorthair

@pwin pwin Awaiting requested review from pwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DCAT2 ratification
Development

Successfully merging this pull request may close these issues.
3 participants
@andrea-perego @riccardoAlbertoni @agbeltran