Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conneg fpwd edits #593

Merged
merged 15 commits into from Nov 16, 2018
Merged

Conneg fpwd edits #593

merged 15 commits into from Nov 16, 2018

Conversation

nicholascar
Copy link
Contributor

No description provided.

Copy link
Contributor

@larsgsvensson larsgsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing Issue 575.1 OK

Copy link
Contributor

@larsgsvensson larsgsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing Issue 575.4 OK

Copy link
Contributor

@larsgsvensson larsgsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure this addresses Antoine's concern in #575 no 10... @aisaac can you have a look at this?

Copy link
Contributor

@larsgsvensson larsgsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing Issue 575 12 OK

Copy link
Contributor

@larsgsvensson larsgsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing 575 13 OK

@larsgsvensson
Copy link
Contributor

The fixing of #579, #570, #571 and #572 all relate to profile-ont and not to conneg-by-ap so I don't feel competent to review those. @rob-metalinkage can you have a look at those and then merge if @aisaac is fine with the changes in commit 798f292

@rob-metalinkage rob-metalinkage merged commit 75ff15f into gh-pages Nov 16, 2018
@nicholascar nicholascar deleted the conneg-fpwd-edits branch November 19, 2018 12:16
@aisaac
Copy link
Contributor

aisaac commented Nov 19, 2018

@larsgsvensson indeed I'm mildly convinced with the proposed solution for #575 10. I guess I was not clear enough... I've detailed this in a new comment for #575. Sorry I've missed all these notifications in the overflow of commits and pulls in the past days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants