-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement vocabulary association mechanisms as an algorithm #2379
Conversation
…an unknown prefix will just return a null value
I think that is great. It would get around the issue of the awkward MUST statements and it works well. Thanks! |
…ection; add optional expansion of epub:type values; rename section to "Processing property values; clarify that reading systems are not required to expand values and may use the values as strings for processing behaviours
Okay, I think this is good to go now. The last commit mostly added explanations for all the steps. I also made a few tweaks to infra-ize things a bit more. The two changes of note are:
|
And as reading the diff is a bit of a nightmare, here's a link to the current section if you want to manually compare against the preview: https://www.w3.org/TR/epub-rs-33/#sec-vocab-assoc |
I have sketched out an implementation in typescript, just to check. Emphasis is on "sketch", but it helped me to follow the infra stuff:-) |
Co-authored-by: Ivan Herman <ivan@w3.org>
…pecs into experiment/issue-2378
s/propertyName/propertyReference/
…ll values require a prefix
…d colon are defined
The issue was discussed in a meeting on 2022-08-04 List of resolutions:
View the transcript2. Re-implement vocabulary association mechanisms as an algorithm (pr epub-specs#2379)See github pull request epub-specs#2379. See github issue epub-specs#2378. See github issue epub-specs#2382. Dave Cramer: there are a couple issues associated with this (#2378, #2382).
|
Per WG resolution, we need an approval of at least @shiestyle and @dauwhe (@wareid and, I presume, @rdeltour being on vacations...). Shinya, Dave, could you do this, please? |
I think they gave us the green light to merge it once we are happy with it. I think the "reviewers" in this case means me and you, as it sound like the group is fine with whatever we resolve on for this given no one's hugely passionate about a feature that's only for internal reading system use... 😄 |
Not looking for approval at this time. Just curious for early feedback on whether this makes sense as a replacement.
I kept the one requirement not to blow up when encountering unknown prefixes.Fixes #2378
Fixes #2382
Preview | Diff