Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify where epub:type is not allowed #2493

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Clarify where epub:type is not allowed #2493

merged 1 commit into from
Dec 2, 2022

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Nov 29, 2022

Restricts is from head element and metadata content to better match the RS restriction.

Fixes #2486


Preview | Diff

Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

Note that this allows epub:type on the html element (not sure if that is intentional or if it should be disallowed there too).

@mattgarrish
Copy link
Member Author

Note that this allows epub:type on the html element (not sure if that is intentional or if it should be disallowed there too).

Intentional. I'm hesitant to change where it's allowed. The restriction pre-3.3 did not forbid it on the root element.

@mattgarrish mattgarrish merged commit 40ecf56 into main Dec 2, 2022
@mattgarrish mattgarrish deleted the fix/issue-2486 branch December 2, 2022 21:12
rdeltour added a commit to w3c/epubcheck that referenced this pull request Dec 13, 2022
This PR implements the latest post-CR update on where `epub:type` is
allowed in HTML content (i.e. everywhere but the `head` element and
metadata content).

See w3c/epub-specs#2493

Fix #1444, Fix #1445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epub:type restricted to palpable content may cause backward incompatibilities
3 participants