Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OPUS media type #2517

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fix OPUS media type #2517

merged 1 commit into from
Jan 9, 2023

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Jan 9, 2023

Switches "audio/opus" in the CMT table to "audio/ogg; codecs=opus" as described in #2516

Fixes #2516


Preview | Diff

@mattgarrish
Copy link
Member Author

FYI, the updated epubcheck is set to be released today, so if we can get some quick approvals for this we might be able to avoid having to defer validation to a future maintenance release.

/cc @avneeshsingh @rdeltour

@mattgarrish
Copy link
Member Author

I've confirmed the media type needs fixing by testing audio elements that specify audio/opus and audio/ogg; codecs=opus in a source element -- the audio/opus declaration is unrecognized while the audio/ogg; codecs=opus declaration allows playback.

I'm going to go ahead and merge this given that result.

Thanks @sewe for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong media type for Opus audio
1 participant