-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating CR testing reports #2524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgarrish
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the URL fixes
mattgarrish
reviewed
Jan 20, 2023
mattgarrish
reviewed
Jan 20, 2023
mattgarrish
reviewed
Jan 20, 2023
Co-authored-by: Matt Garrish <mattgarrish@users.noreply.github.com>
Co-authored-by: Matt Garrish <mattgarrish@users.noreply.github.com>
Co-authored-by: Matt Garrish <mattgarrish@users.noreply.github.com>
Co-authored-by: Matt Garrish <mattgarrish@users.noreply.github.com>
Co-authored-by: Matt Garrish <mattgarrish@users.noreply.github.com>
wareid
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gone through all the report documents on the spec repository to refresh them and to make them usable for the official PR review request. All the changes are stylistic.
The usual preview mechanism does not work, so here is the list of documents to look at:
For reviewing: the first two documents are HTML files in respec; while the last three documents are also respec files, but the only thing they do is to include a markdown file. Proposed changes may have to be made on those.