Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve reporting of invalid URL host parts #1131

Merged
merged 1 commit into from
Apr 28, 2020
Merged

fix: improve reporting of invalid URL host parts #1131

merged 1 commit into from
Apr 28, 2020

Conversation

rdeltour
Copy link
Member

@rdeltour
fix: improve reporting of invalid URL host parts
d2728ee 
- fix #1034: make the message more genric ("Couldn't parse host…")
- fix #1079: don't report underscores used in the URL host part
- expand test `testValidateXHTMLUrlChecksInvalid`
@rdeltour rdeltour added the status: needs review Needs to be reviewed by a team member before further processing label Apr 27, 2020
@rdeltour rdeltour added this to the 4.2.3 milestone Apr 27, 2020
@rdeltour rdeltour self-assigned this Apr 27, 2020
@rdeltour rdeltour merged commit d2728ee into master Apr 28, 2020
@rdeltour rdeltour deleted the fix/1034/url-host-warning branch April 28, 2020 16:37
tofi86
tofi86 reviewed Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@tofi86 tofi86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tofi86
tofi86 reviewed Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@tofi86 tofi86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofi86 tofi86 tofi86 left review comments

@mattgarrish mattgarrish mattgarrish approved these changes

Assignees

@rdeltour rdeltour

Labels
status: needs review Needs to be reviewed by a team member before further processing
Projects
None yet
Milestone
4.2.3
3 participants
@rdeltour @tofi86 @mattgarrish